[gtk/wip.win32.fixes: 17/21] gstglsink.c: Some cleanups
- From: Chun-wei Fan <fanchunwei src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/wip.win32.fixes: 17/21] gstglsink.c: Some cleanups
- Date: Fri, 21 May 2021 04:53:35 +0000 (UTC)
commit 58cd8280c647729a8772f3739abaa6deb5c3b782
Author: Chun-wei Fan <fanchunwei src gnome org>
Date: Thu May 20 12:21:54 2021 +0800
gstglsink.c: Some cleanups
Remove some leftovers, and update the comment block as needed
modules/media/gtkgstsink.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
---
diff --git a/modules/media/gtkgstsink.c b/modules/media/gtkgstsink.c
index c6f7d61ea2..7452ee7a4b 100644
--- a/modules/media/gtkgstsink.c
+++ b/modules/media/gtkgstsink.c
@@ -482,15 +482,13 @@ gtk_gst_sink_initialize_gl (GtkGstSink *self)
if (gl_handle)
{
- gchar *gl_api_str = NULL;
- gpointer display_ptr = NULL;
-
/*
* We must force a win32 GstGL display type and if using desktop GL, the GL_Platform to be WGL
* and an appropriate GstGL API depending on the gl_api we receive. We also ensure that we use
- * an EGL GstGL API if we are using EGL in GDK. Envvars are required, unfortunately, so that
- * gst_gl_display_new() does things correctly if we have GstGL built with both EGL and WGL
- * support, otherwise gst_gl_display_new() will assume an EGL display, which won't work for us
+ * an EGL GstGL API if we are using EGL in GDK. Envvars are required, unless
+ * gst_gl_display_new_with_type() is available, unfortunately, so that gst_gl_display_new() does
+ * things correctly if we have GstGL built with both EGL and WGL support for the WGL case,
+ * otherwise gst_gl_display_new() will assume an EGL display, which won't work for us
*/
if (gl_api == GST_GL_API_OPENGL3 || gl_api == GST_GL_API_OPENGL)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]