[libsoup] io-http2: last_stream_id is not unsigned
- From: Carlos Garcia Campos <carlosgc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libsoup] io-http2: last_stream_id is not unsigned
- Date: Thu, 27 May 2021 17:43:27 +0000 (UTC)
commit 6fd27d07f1001def53e4965fb24df4bd2e3e4139
Author: Carlos Garcia Campos <cgarcia igalia com>
Date: Thu May 27 19:31:31 2021 +0200
io-http2: last_stream_id is not unsigned
libsoup/http2/soup-client-message-io-http2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/libsoup/http2/soup-client-message-io-http2.c b/libsoup/http2/soup-client-message-io-http2.c
index e7695b0c..fbb73f7f 100644
--- a/libsoup/http2/soup-client-message-io-http2.c
+++ b/libsoup/http2/soup-client-message-io-http2.c
@@ -385,7 +385,7 @@ on_begin_frame_callback (nghttp2_session *session,
static void
handle_goaway (SoupClientMessageIOHTTP2 *io,
guint32 error_code,
- guint32 last_stream_id)
+ int32_t last_stream_id)
{
GHashTableIter iter;
SoupHTTP2MessageData *data;
@@ -394,7 +394,7 @@ handle_goaway (SoupClientMessageIOHTTP2 *io,
while (g_hash_table_iter_next (&iter, NULL, (gpointer*)&data)) {
/* If there is no error it is a graceful shutdown and
* existing messages can be handled otherwise it is a fatal error */
- if ((error_code == 0 && data->stream_id > last_stream_id) ||
+ if ((error_code == 0 && (int32_t)data->stream_id > last_stream_id) ||
data->state < STATE_READ_DONE) {
/* TODO: We can restart unfinished messages */
set_error_for_data (data, g_error_new (G_IO_ERROR, G_IO_ERROR_FAILED,
@@ -414,7 +414,7 @@ on_frame_recv_callback (nghttp2_session *session,
h2_debug (io, data, "[RECV] [%s] Recieved (%u)", frame_type_to_string (frame->hd.type),
frame->hd.flags);
if (frame->hd.type == NGHTTP2_GOAWAY) {
- h2_debug (io, data, "[RECV] GOAWAY: error=%s, last_stream_id=%u %s",
+ h2_debug (io, data, "[RECV] GOAWAY: error=%s, last_stream_id=%d %s",
nghttp2_http2_strerror (frame->goaway.error_code),
frame->goaway.last_stream_id,
frame->goaway.opaque_data ? (char *)frame->goaway.opaque_data : "");
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]