[gnome-software: 79/110] Remove a lot of packing properties
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software: 79/110] Remove a lot of packing properties
- Date: Tue, 5 Oct 2021 20:32:41 +0000 (UTC)
commit 64483431111a78f6e52cf287d581379e437e153a
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Thu Aug 26 00:33:49 2021 -0300
Remove a lot of packing properties
Remove all of them.
src/gs-age-rating-context-dialog.ui | 6 ------
src/gs-app-addon-row.ui | 3 ---
src/gs-app-context-bar.ui | 24 ------------------------
src/gs-app-row.ui | 12 ------------
src/gs-app-translation-dialog.ui | 6 ------
src/gs-app-version-history-row.ui | 3 ---
src/gs-basic-auth-dialog.ui | 11 -----------
src/gs-context-dialog-row.ui | 10 +---------
src/gs-details-page.ui | 26 +++++++-------------------
src/gs-hardware-support-context-dialog.ui | 6 ------
src/gs-license-tile.ui | 9 ---------
src/gs-metered-data-dialog.ui | 4 ----
src/gs-review-dialog.ui | 6 ------
src/gs-review-row.ui | 6 ------
src/gs-safety-context-dialog.ui | 6 ------
src/gs-screenshot-carousel.ui | 6 ------
src/gs-shell.ui | 10 ++--------
src/gs-storage-context-dialog.ui | 6 ------
src/gs-updates-page.ui | 3 ---
src/gs-updates-section.ui | 3 ---
src/gs-upgrade-banner.ui | 12 ------------
21 files changed, 10 insertions(+), 168 deletions(-)
---
diff --git a/src/gs-age-rating-context-dialog.ui b/src/gs-age-rating-context-dialog.ui
index 71584cdcb..6e7dee4f2 100644
--- a/src/gs-age-rating-context-dialog.ui
+++ b/src/gs-age-rating-context-dialog.ui
@@ -46,14 +46,8 @@
<relation name="labelled-by">title</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
diff --git a/src/gs-app-addon-row.ui b/src/gs-app-addon-row.ui
index de0373e31..5eedee273 100644
--- a/src/gs-app-addon-row.ui
+++ b/src/gs-app-addon-row.ui
@@ -78,9 +78,6 @@
</object>
</child>
</object>
- <packing>
- <property name="pack_type">end</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-app-context-bar.ui b/src/gs-app-context-bar.ui
index 2545359d2..c4709c17b 100644
--- a/src/gs-app-context-bar.ui
+++ b/src/gs-app-context-bar.ui
@@ -48,14 +48,8 @@
<relation name="details">storage_tile_description</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
<object class="GtkLabel" id="storage_tile_title">
@@ -118,14 +112,8 @@
<relation name="details">safety_tile_description</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
<object class="GtkLabel" id="safety_tile_title">
@@ -198,14 +186,8 @@
<relation name="details">hardware_support_tile_description</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
<object class="GtkLabel" id="hardware_support_tile_title">
@@ -269,14 +251,8 @@
<relation name="details">age_rating_tile_description</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
<object class="GtkLabel" id="age_rating_tile_title">
diff --git a/src/gs-app-row.ui b/src/gs-app-row.ui
index 57412119d..7d993990c 100644
--- a/src/gs-app-row.ui
+++ b/src/gs-app-row.ui
@@ -218,9 +218,6 @@
</object>
</child>
</object>
- <packing>
- <property name="pack_type">end</property>
- </packing>
</child>
<child>
<object class="GtkSpinner" id="spinner">
@@ -229,9 +226,6 @@
<property name="margin_end">12</property>
<property name="halign">end</property>
</object>
- <packing>
- <property name="pack_type">end</property>
- </packing>
</child>
<child>
<object class="GtkLabel" id="label">
@@ -240,9 +234,6 @@
<property name="margin_end">12</property>
<property name="halign">end</property>
</object>
- <packing>
- <property name="pack_type">end</property>
- </packing>
</child>
</object>
</child>
@@ -259,9 +250,6 @@
<class name="dim-label"/>
</style>
</object>
- <packing>
- <property name="pack_type">end</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-app-translation-dialog.ui b/src/gs-app-translation-dialog.ui
index 6b9a4715f..af603344d 100644
--- a/src/gs-app-translation-dialog.ui
+++ b/src/gs-app-translation-dialog.ui
@@ -47,14 +47,8 @@
<relation name="labelled-by">title</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
diff --git a/src/gs-app-version-history-row.ui b/src/gs-app-version-history-row.ui
index 97b016dbb..8f962db08 100644
--- a/src/gs-app-version-history-row.ui
+++ b/src/gs-app-version-history-row.ui
@@ -40,9 +40,6 @@
<class name="dim-label"/>
</style>
</object>
- <packing>
- <property name="pack_type">end</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-basic-auth-dialog.ui b/src/gs-basic-auth-dialog.ui
index 8487e56ac..075e28898 100644
--- a/src/gs-basic-auth-dialog.ui
+++ b/src/gs-basic-auth-dialog.ui
@@ -32,9 +32,6 @@
<class name="text-button"/>
</style>
</object>
- <packing>
- <property name="pack_type">start</property>
- </packing>
</child>
<child>
<object class="GtkButton" id="login_button">
@@ -52,9 +49,6 @@
<class name="suggested-action"/>
</style>
</object>
- <packing>
- <property name="pack_type">end</property>
- </packing>
</child>
</object>
</child>
@@ -175,11 +169,6 @@
</object>
</child>
</object>
- <packing>
- <property name="expand">False</property>
- <property name="fill">True</property>
- <property name="position">0</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-context-dialog-row.ui b/src/gs-context-dialog-row.ui
index b2f252a58..8bf885754 100644
--- a/src/gs-context-dialog-row.ui
+++ b/src/gs-context-dialog-row.ui
@@ -36,13 +36,11 @@
<relation name="details">description</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
<child>
<object class="GtkLabel" id="lozenge_content_text">
<property name="halign">center</property>
+ <property name="hexpand">True</property>
<!-- this is a placeholder: the text is actually set in code -->
<property name="label">20 MB</property>
<property name="visible">False</property>
@@ -52,14 +50,8 @@
<relation name="details">description</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
<object class="GtkBox">
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index bd4291926..c97a0f77b 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -73,8 +73,8 @@
<property name="spacing">12</property>
<property name="visible">True</property>
<signal name="response"
handler="gs_details_page_translation_infobar_response_cb"/>
- <child internal-child="content_area">
- <object class="GtkBox">
+ <child>
+ <object class="GtkCenterBox">
<property name="orientation">horizontal</property>
<property name="visible">True</property>
<child type="center">
@@ -86,15 +86,12 @@
<property name="xalign">0</property>
</object>
</child>
- <child>
+ <child type="end">
<object class="GtkButton" id="translation_infobar_button">
<property name="label" translatable="yes">Help _Translate</property>
<property name="use-underline">True</property>
<property name="visible">True</property>
</object>
- <packing>
- <property name="pack-type">end</property>
- </packing>
</child>
</object>
</child>
@@ -302,11 +299,10 @@
</object>
</child>
<child>
- <object class="GtkBox">
+ <object class="GtkCenterBox">
<property name="visible" bind-source="button_cancel"
bind-property="visible" bind-flags="sync-create"/>
- <property name="spacing">3</property>
<property name="orientation">vertical</property>
- <property name="valign">fill</property>
+ <property name="valign">center</property>
<child type="center">
<object class="GsProgressButton" id="button_cancel">
<property name="visible">False</property>
@@ -315,13 +311,14 @@
<property name="can_focus">True</property>
<property name="receives_default">True</property>
<property name="valign">center</property>
+ <property name="margin-bottom">3</property>
<signal name="clicked"
handler="gs_details_page_app_cancel_button_cb"/>
<style>
<class name="list-button"/>
</style>
</object>
</child>
- <child>
+ <child type="end">
<object class="GtkBox">
<property name="visible"
bind-source="label_progress_status" bind-property="visible" bind-flags="sync-create"/>
<property name="spacing">3</property>
@@ -347,9 +344,6 @@
</object>
</child>
</object>
- <packing>
- <property name="pack-type">end</property>
- </packing>
</child>
</object>
</child>
@@ -365,9 +359,6 @@
<class name="suggested-action"/>
</style>
</object>
- <packing>
- <property name="pack-type">end</property>
- </packing>
</child>
<child>
<object class="GtkButton" id="button_details_remove_shortcut">
@@ -378,9 +369,6 @@
<property name="valign">center</property>
<signal name="clicked"
handler="gs_details_page_app_remove_shortcut_button_cb"/>
</object>
- <packing>
- <property name="pack-type">end</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-hardware-support-context-dialog.ui b/src/gs-hardware-support-context-dialog.ui
index 125581716..de31b5748 100644
--- a/src/gs-hardware-support-context-dialog.ui
+++ b/src/gs-hardware-support-context-dialog.ui
@@ -46,14 +46,8 @@
<relation name="labelled-by">title</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
diff --git a/src/gs-license-tile.ui b/src/gs-license-tile.ui
index 7e4843c83..ff57fc3a4 100644
--- a/src/gs-license-tile.ui
+++ b/src/gs-license-tile.ui
@@ -47,9 +47,6 @@
<property name="icon-name">heart-filled-symbolic</property>
<property name="visible">True</property>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
</child>
@@ -67,9 +64,6 @@
<property name="icon-name">system-users-symbolic</property>
<property name="visible">True</property>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
</child>
@@ -87,9 +81,6 @@
<property name="icon-name">sign-language-symbolic</property>
<property name="visible">True</property>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-metered-data-dialog.ui b/src/gs-metered-data-dialog.ui
index dfbbd5b08..73605e76f 100644
--- a/src/gs-metered-data-dialog.ui
+++ b/src/gs-metered-data-dialog.ui
@@ -61,10 +61,6 @@ Alternatively, if the current network has been inÂcorrectly identified as being
</object>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- <property name="expand">False</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-review-dialog.ui b/src/gs-review-dialog.ui
index ac8904b45..28271f719 100644
--- a/src/gs-review-dialog.ui
+++ b/src/gs-review-dialog.ui
@@ -25,9 +25,6 @@
<property name="receives_default">True</property>
<property name="use_underline">True</property>
</object>
- <packing>
- <property name="pack-type">start</property>
- </packing>
</child>
<child>
<object class="GtkButton" id="post_button">
@@ -38,9 +35,6 @@
<property name="use_underline">True</property>
<property name="sensitive">False</property>
</object>
- <packing>
- <property name="pack-type">end</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-review-row.ui b/src/gs-review-row.ui
index 557930c69..529a3cedc 100644
--- a/src/gs-review-row.ui
+++ b/src/gs-review-row.ui
@@ -139,9 +139,6 @@
<property name="halign">end</property>
<property name="has-frame">False</property>
</object>
- <packing>
- <property name="pack_type">end</property>
- </packing>
</child>
<child>
<object class="GtkButton" id="button_remove">
@@ -152,9 +149,6 @@
<property name="halign">end</property>
<property name="has-frame">False</property>
</object>
- <packing>
- <property name="pack_type">end</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-safety-context-dialog.ui b/src/gs-safety-context-dialog.ui
index 5af8107ca..bb5d217bc 100644
--- a/src/gs-safety-context-dialog.ui
+++ b/src/gs-safety-context-dialog.ui
@@ -46,14 +46,8 @@
<relation name="labelled-by">title</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
diff --git a/src/gs-screenshot-carousel.ui b/src/gs-screenshot-carousel.ui
index bac5377fc..2aefce757 100644
--- a/src/gs-screenshot-carousel.ui
+++ b/src/gs-screenshot-carousel.ui
@@ -67,9 +67,6 @@
</object>
</child>
</object>
- <packing>
- <property name="pass-through">True</property>
- </packing>
</child>
<child type="overlay">
<object class="GtkRevealer" id="button_next_revealer">
@@ -109,9 +106,6 @@
</object>
</child>
</object>
- <packing>
- <property name="pass-through">True</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-shell.ui b/src/gs-shell.ui
index 85b042bcd..9110287ca 100644
--- a/src/gs-shell.ui
+++ b/src/gs-shell.ui
@@ -185,7 +185,7 @@
<property name="hexpand">True</property>
<property name="show-end-title-buttons">True</property>
<property name="centering-policy">strict</property>
- <child>
+ <child type="start">
<object class="GtkToggleButton" id="search_button">
<property name="visible">True</property>
<property name="can_focus">True</property>
@@ -205,11 +205,8 @@
</object>
</child>
</object>
- <packing>
- <property name="pack-type">start</property>
- </packing>
</child>
- <child>
+ <child type="end">
<object class="GtkMenuButton" id="menu_button">
<property name="visible">True</property>
<property name="can_focus">True</property>
@@ -229,9 +226,6 @@
<class name="image-button"/>
</style>
</object>
- <packing>
- <property name="pack-type">end</property>
- </packing>
</child>
<child type="title">
<object class="AdwViewSwitcherTitle" id="title_switcher">
diff --git a/src/gs-storage-context-dialog.ui b/src/gs-storage-context-dialog.ui
index 0297d5d3e..f536a9fa7 100644
--- a/src/gs-storage-context-dialog.ui
+++ b/src/gs-storage-context-dialog.ui
@@ -46,14 +46,8 @@
<relation name="labelled-by">title</relation>
</accessibility>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
- <packing>
- <property name="fill">False</property>
- </packing>
</child>
<child>
diff --git a/src/gs-updates-page.ui b/src/gs-updates-page.ui
index 356486ca2..b1ead7b38 100644
--- a/src/gs-updates-page.ui
+++ b/src/gs-updates-page.ui
@@ -253,9 +253,6 @@
</object>
</child>
</object>
- <packing>
- <property name="expand">True</property>
- </packing>
</child>
</object>
</property>
diff --git a/src/gs-updates-section.ui b/src/gs-updates-section.ui
index d9bb75121..fcda529a1 100644
--- a/src/gs-updates-section.ui
+++ b/src/gs-updates-section.ui
@@ -76,9 +76,6 @@
</child>
</object>
- <packing>
- <property name="pack-type">end</property>
- </packing>
</child>
</object>
</child>
diff --git a/src/gs-upgrade-banner.ui b/src/gs-upgrade-banner.ui
index 162f681d4..a6feb7d21 100644
--- a/src/gs-upgrade-banner.ui
+++ b/src/gs-upgrade-banner.ui
@@ -125,10 +125,6 @@
<property name="label"></property> <!-- space-taker -->
<property name="halign">start</property>
</object>
- <packing>
- <property name="expand">False</property>
- <property name="fill">False</property>
- </packing>
</child>
<child>
<object class="GtkBox" id="hbox_upgrades_downloading">
@@ -166,10 +162,6 @@
</object>
</child>
</object>
- <packing>
- <property name="expand">True</property>
- <property name="fill">True</property>
- </packing>
</child>
<child>
@@ -194,10 +186,6 @@
</object>
</child>
</object>
- <packing>
- <property name="expand">False</property>
- <property name="fill">False</property>
- </packing>
</child>
</object>
</child>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
