[tracker/wip/carlosg/anonymous-nodes: 6/24] libtracker-data: Avoid pointless queries on predicate IDs
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tracker/wip/carlosg/anonymous-nodes: 6/24] libtracker-data: Avoid pointless queries on predicate IDs
- Date: Fri, 8 Oct 2021 09:40:54 +0000 (UTC)
commit 39982d091864f3d4f112c5a6cfa308975cc6b471
Author: Carlos Garnacho <carlosg gnome org>
Date: Tue Sep 21 16:43:37 2021 +0200
libtracker-data: Avoid pointless queries on predicate IDs
These are already readily available from the TrackerOntology, there
is no need to query the database for these IDs.
src/libtracker-data/tracker-data-update.c | 30 ++----------------------------
1 file changed, 2 insertions(+), 28 deletions(-)
---
diff --git a/src/libtracker-data/tracker-data-update.c b/src/libtracker-data/tracker-data-update.c
index 60873b84e..b27f2da1c 100644
--- a/src/libtracker-data/tracker-data-update.c
+++ b/src/libtracker-data/tracker-data-update.c
@@ -2654,10 +2654,9 @@ tracker_data_insert_statement_with_uri (TrackerData *data,
TrackerClass *class;
TrackerProperty *property;
gint prop_id = 0;
- gint final_prop_id = 0, object_id = 0;
+ gint object_id = 0;
gboolean change = FALSE;
TrackerOntologies *ontologies;
- TrackerDBInterface *iface;
const gchar *object_str;
g_return_if_fail (subject != NULL);
@@ -2666,7 +2665,6 @@ tracker_data_insert_statement_with_uri (TrackerData *data,
g_return_if_fail (data->in_transaction);
ontologies = tracker_data_manager_get_ontologies (data->manager);
- iface = tracker_data_manager_get_writable_db_interface (data->manager);
property = tracker_ontologies_get_property_by_uri (ontologies, predicate);
if (property == NULL) {
@@ -2711,24 +2709,12 @@ tracker_data_insert_statement_with_uri (TrackerData *data,
}
if (change) {
- final_prop_id = prop_id;
-
- if (final_prop_id == 0) {
- final_prop_id = tracker_data_query_resource_id (data->manager,
- iface,
- predicate,
- error);
- }
-
- if (final_prop_id == 0)
- return;
-
object_id = query_resource_id (data, object_str, error);
if (object_id == 0)
return;
tracker_data_dispatch_insert_statement_callbacks (data,
- final_prop_id,
+ prop_id,
object_id);
}
}
@@ -2747,7 +2733,6 @@ tracker_data_insert_statement_with_string (TrackerData *data,
gboolean change;
gint pred_id = 0;
TrackerOntologies *ontologies;
- TrackerDBInterface *iface;
g_return_if_fail (subject != NULL);
g_return_if_fail (predicate != NULL);
@@ -2755,7 +2740,6 @@ tracker_data_insert_statement_with_string (TrackerData *data,
g_return_if_fail (data->in_transaction);
ontologies = tracker_data_manager_get_ontologies (data->manager);
- iface = tracker_data_manager_get_writable_db_interface (data->manager);
property = tracker_ontologies_get_property_by_uri (ontologies, predicate);
if (property == NULL) {
@@ -2785,16 +2769,6 @@ tracker_data_insert_statement_with_string (TrackerData *data,
}
if (change) {
- if (pred_id == 0) {
- pred_id = tracker_data_query_resource_id (data->manager,
- iface,
- predicate,
- error);
- }
-
- if (pred_id == 0)
- return;
-
tracker_data_dispatch_insert_statement_callbacks (data,
pred_id,
0 /* Always a literal */);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]