[gnome-software/mwleeds/fix-deprecated-install] flatpak: Fix capitalization of boolean value in tests



commit 2e77ce87c12509c178922513052fef210f7e22c7
Author: Phaedrus Leeds <mwleeds protonmail com>
Date:   Mon Oct 11 15:45:25 2021 -0700

    flatpak: Fix capitalization of boolean value in tests
    
    GLib recognizes "false" but not "False" as false in
    g_key_file_get_boolean(). However, because that function returns false
    when either the value is false or the function errored out (genius!),
    and libflatpak doesn't check for an error in this case, the incorrect
    spelling usually has no effect. But with the recent changes in
    gs_flatpak_file_to_app_ref(), the "False" spelling leads to a failure of
    the unit tests.

 plugins/flatpak/gs-self-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/plugins/flatpak/gs-self-test.c b/plugins/flatpak/gs-self-test.c
index 2789d4f70..10243d7da 100644
--- a/plugins/flatpak/gs-self-test.c
+++ b/plugins/flatpak/gs-self-test.c
@@ -56,7 +56,7 @@ gs_flatpak_test_write_ref_file (const gchar *filename, const gchar *url, const g
        g_string_append (str, "Name=org.test.Chiron\n");
        g_string_append (str, "Branch=master\n");
        g_string_append_printf (str, "Url=%s\n", url);
-       g_string_append (str, "IsRuntime=False\n");
+       g_string_append (str, "IsRuntime=false\n");
        g_string_append (str, "Comment=Single line synopsis\n");
        g_string_append (str, "Description=A Testing Application\n");
        g_string_append (str, "Icon=https://getfedora.org/static/images/fedora-logotext.png\n";);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]