[nautilus/wip/antoniof/try-admin-backend-for-file-ops: 3/11] file-operations: Adapt copy_job_setup() for duplication

[António Fernandes <antoniof src gnome org>]

commit 51eff308ae57f02de80bfaf60cf01a6ab8481e50
Author: António Fernandes <antoniof gnome org>
Date:   Sat Oct 16 00:07:25 2021 +0100

    file-operations: Adapt copy_job_setup() for duplication
    
    The duplicate task doesn't have a *_job_setup() helper.
    
    It can reuse the 'copy' one with minor adaptaions. The duplication is
    still easily identified by having a NULL destination.

 src/nautilus-file-operations.c | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)
---
diff --git a/src/nautilus-file-operations.c b/src/nautilus-file-operations.c
index 18c51504b..2c4f3ff13 100644
--- a/src/nautilus-file-operations.c
+++ b/src/nautilus-file-operations.c
@@ -5981,15 +5981,24 @@ copy_job_setup (GList                          *files,
                 gpointer                        done_callback_data)
 {
     CopyMoveJob *job;
+    GFile *progress_dest = target_dir;
+    g_autoptr (GFile) src_dir = NULL;
 
     job = op_job_new (CopyMoveJob, parent_window, dbus_data);
     job->done_callback = done_callback;
     job->done_callback_data = done_callback_data;
     job->files = g_list_copy_deep (files, (GCopyFunc) g_object_ref, NULL);
-    job->destination = g_object_ref (target_dir);
+    g_set_object (&job->destination, target_dir);
+    if (progress_dest == NULL)
+    {
+        /* Duplication operation doesn't have a destination, but progress info
+         * demands one. */
+        src_dir = g_file_get_parent (files->data);
+        progress_dest = src_dir;
+    }
     /* Need to indicate the destination for the operation notification open
      * button. */
-    nautilus_progress_info_set_destination (((CommonJob *) job)->progress, target_dir);
+    nautilus_progress_info_set_destination (((CommonJob *) job)->progress, progress_dest);
     job->debuting_files = g_hash_table_new_full (g_file_hash, (GEqualFunc) g_file_equal, g_object_unref, 
NULL);
 
     return job;
@@ -7110,20 +7119,13 @@ nautilus_file_operations_duplicate (GList                          *files,
 {
     g_autoptr (GTask) task = NULL;
     CopyMoveJob *job;
-    g_autoptr (GFile) parent = NULL;
 
-    job = op_job_new (CopyMoveJob, parent_window, dbus_data);
-    job->done_callback = done_callback;
-    job->done_callback_data = done_callback_data;
-    job->files = g_list_copy_deep (files, (GCopyFunc) g_object_ref, NULL);
-    job->destination = NULL;
-    /* Duplicate files doesn't have a destination, since is the same as source.
-     * For that set as destination the source parent folder */
-    parent = g_file_get_parent (files->data);
-    /* Need to indicate the destination for the operation notification open
-     * button. */
-    nautilus_progress_info_set_destination (((CommonJob *) job)->progress, parent);
-    job->debuting_files = g_hash_table_new_full (g_file_hash, (GEqualFunc) g_file_equal, g_object_unref, 
NULL);
+    job = copy_job_setup (files,
+                          NULL,
+                          parent_window,
+                          dbus_data,
+                          done_callback,
+                          done_callback_data);
 
     if (!nautilus_file_undo_manager_is_operating ())
     {