[gnome-software/wip/mcrha/odrs-download-etag] Apply 3 suggestion(s) to 1 file(s)



commit b2a57ea3ad49fdc9ba94da24290f39a0d9ac212d
Author: Philip Withnall <philip tecnocode co uk>
Date:   Tue Oct 19 10:14:03 2021 +0000

    Apply 3 suggestion(s) to 1 file(s)

 lib/gs-plugin.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/lib/gs-plugin.c b/lib/gs-plugin.c
index ff96c474c..f314c2d4c 100644
--- a/lib/gs-plugin.c
+++ b/lib/gs-plugin.c
@@ -1087,11 +1087,11 @@ gs_plugin_download_file (GsPlugin *plugin,
 /**
  * gs_plugin_download_file_full:
  * @plugin: a #GsPlugin
- * @app: a #GsApp, or %NULL
+ * @app: (nullable): a #GsApp, or %NULL
  * @uri: a remote URI
  * @filename: a local filename
  * @last_etag: (nullable): a last etag, or %NULL
- * @out_new_etag: (nullable) (out): where to store a new etag, or %NULL
+ * @out_new_etag: (nullable) (optional) (out) (transfer full): where to store a new etag, or %NULL
  * @cancellable: a #GCancellable, or %NULL
  * @error: a #GError, or %NULL
  *
@@ -1206,6 +1206,8 @@ gs_plugin_download_file_full (GsPlugin *plugin,
                new_etag = soup_message_headers_get_one (msg->response_headers, "ETag");
                if (new_etag != NULL && *new_etag != '\0')
                        *out_new_etag = g_strdup (new_etag);
+               else
+                       *out_new_etag = NULL;
        }
        return TRUE;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]