[librsvg: 9/18] Remove comment that will become irrelevant soon
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [librsvg: 9/18] Remove comment that will become irrelevant soon
- Date: Tue, 26 Oct 2021 02:33:05 +0000 (UTC)
commit e52ada9704dad98a89905be9279ce196e86003bd
Author: Federico Mena Quintero <federico gnome org>
Date: Mon Oct 25 18:32:46 2021 -0500
Remove comment that will become irrelevant soon
We'll implement line-height by hand with the SVG2 text layout algorithm.
Part-of: <https://gitlab.gnome.org/GNOME/librsvg/-/merge_requests/621>
src/text.rs | 12 ------------
1 file changed, 12 deletions(-)
---
diff --git a/src/text.rs b/src/text.rs
index eb276a77..66e478a9 100644
--- a/src/text.rs
+++ b/src/text.rs
@@ -1185,18 +1185,6 @@ fn create_pango_layout(draw_ctx: &DrawingCtx, props: &FontProperties, text: &str
let layout = pango::Layout::new(&pango_context);
- // FIXME: For now we ignore the `line-height` property, even though we parse it.
- // We would need to do something like this:
- //
- // layout.set_line_spacing(0.0); // "actually use the spacing I'll give you"
- // layout.set_spacing(to_pango_units(???));
- //
- // However, Layout::set_spacing() takes an inter-line spacing (from the baseline of
- // one line to the top of the next line), not the line height (from baseline to
- // baseline).
- //
- // Maybe we need to implement layout of individual lines by hand.
-
let attr_list = pango::AttrList::new();
add_pango_attributes(&attr_list, &pango_context, props);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]