[gnome-shell/wip/carlosg/im-untimely-preedit: 2/3] inputMethod: Do not communicate preedit text change on reset




commit 8f7f794797dd8ea7d1f16eed48309dfa51b38134
Author: Carlos Garnacho <carlosg gnome org>
Date:   Fri Oct 29 16:43:15 2021 +0200

    inputMethod: Do not communicate preedit text change on reset
    
    This is now done in the ClutterInputFocus for us, since
    https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1940. There
    is no need to duplicate this call, and it happens to cause undesired
    scrolling to content in some cases when this reset happens during
    a change in the IM focused client state.
    
    Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4647

 js/misc/inputMethod.js | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
---
diff --git a/js/misc/inputMethod.js b/js/misc/inputMethod.js
index 7de7540d3f..71dff84f58 100644
--- a/js/misc/inputMethod.js
+++ b/js/misc/inputMethod.js
@@ -186,11 +186,7 @@ class InputMethod extends Clutter.InputMethod {
             this._emitRequestSurrounding();
         }
 
-        if (this._preeditStr !== null) {
-            // Unset any preedit text
-            this.set_preedit_text(null, 0, Clutter.PreeditResetMode.CLEAR);
-            this._preeditStr = null;
-        }
+        this._preeditStr = null;
     }
 
     vfunc_set_cursor_location(rect) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]