[gnome-software/1712-clicking-fedora-flathub-selection-does-not-update-the-filtered-flathub-appstream-metadata: 4/5] flatpak: Only mark caches as obsolete on source install

[Milan Crha <mcrha src gnome org>]

commit 3961f569a2a07e830f5f90ea616c99c4b227527c
Author: Milan Crha <mcrha redhat com>
Date:   Wed Apr 20 15:57:29 2022 +0200

    flatpak: Only mark caches as obsolete on source install
    
    When adding/enabling a remote, just mark caches as obsolete, thus anything
    later will refresh internal cache once needed. This helps to speed up
    the operation.

 plugins/flatpak/gs-flatpak.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
---
diff --git a/plugins/flatpak/gs-flatpak.c b/plugins/flatpak/gs-flatpak.c
index df81ea90d..a77230ab2 100644
--- a/plugins/flatpak/gs-flatpak.c
+++ b/plugins/flatpak/gs-flatpak.c
@@ -1752,22 +1752,16 @@ gs_flatpak_app_install_source (GsFlatpak *self,
                gs_flatpak_error_convert (error);
                g_prefix_error (error, "cannot modify remote: ");
                gs_app_set_state_recover (app);
+               gs_flatpak_internal_data_changed (self);
                return FALSE;
        }
 
-       /* invalidate cache */
-       g_rw_lock_reader_lock (&self->silo_lock);
-       if (self->silo != NULL)
-               xb_silo_invalidate (self->silo);
-       g_rw_lock_reader_unlock (&self->silo_lock);
+       /* Mark the internal cache as obsolete. */
+       gs_flatpak_internal_data_changed (self);
 
        /* success */
        gs_app_set_state (app, GS_APP_STATE_INSTALLED);
 
-       /* This can fail silently, it's only to update necessary caches, to provide
-        * up-to-date information after the successful remote enable/install. */
-       gs_flatpak_refresh (self, 1, interactive, cancellable, NULL);
-
        gs_plugin_repository_changed (self->plugin, app);
 
        return TRUE;