[totem/wip/hadess/simplify-text-sub: 2/5] backend: Simplify _set_language() implementation
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [totem/wip/hadess/simplify-text-sub: 2/5] backend: Simplify _set_language() implementation
- Date: Fri, 11 Feb 2022 22:04:04 +0000 (UTC)
commit 6b32755b60876aa9b38442e40840e233ff488c31
Author: Bastien Nocera <hadess hadess net>
Date: Fri Feb 11 20:06:47 2022 +0100
backend: Simplify _set_language() implementation
To be more like the _set_subtitle() one.
src/backend/bacon-video-widget.c | 23 +----------------------
1 file changed, 1 insertion(+), 22 deletions(-)
---
diff --git a/src/backend/bacon-video-widget.c b/src/backend/bacon-video-widget.c
index 3d9e6ad29..f500607ac 100644
--- a/src/backend/bacon-video-widget.c
+++ b/src/backend/bacon-video-widget.c
@@ -2611,20 +2611,6 @@ bacon_video_widget_get_subtitle (BaconVideoWidget * bvw)
return subtitle;
}
-static gboolean
-sublang_is_valid (int sublang,
- int n_sublang)
-{
- if (sublang == BVW_TRACK_AUTO ||
- sublang == BVW_TRACK_NONE)
- return TRUE;
- if (sublang < 0)
- return FALSE;
- if (sublang >= n_sublang)
- return FALSE;
- return TRUE;
-}
-
static BvwLangInfo *
find_info_for_id (GList *list,
int id)
@@ -3064,22 +3050,15 @@ void
bacon_video_widget_set_language (BaconVideoWidget * bvw, int language)
{
GstTagList *tags;
- int n_lang;
g_return_if_fail (BACON_IS_VIDEO_WIDGET (bvw));
g_return_if_fail (bvw->play != NULL);
-
- g_object_get (bvw->play, "n-audio", &n_lang, NULL);
-
- g_return_if_fail (sublang_is_valid (language, n_lang));
+ g_return_if_fail (find_info_for_id (bvw->languages, language) != NULL);
GST_DEBUG ("setting language to %d", language);
g_object_set (bvw->play, "current-audio", language, NULL);
- g_object_get (bvw->play, "current-audio", &language, NULL);
- GST_DEBUG ("current-audio now: %d", language);
-
g_signal_emit_by_name (G_OBJECT (bvw->play), "get-audio-tags", language, &tags);
bvw_update_tags (bvw, tags, "audio");
if (update_languages_tracks (bvw))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]