[gnome-shell/wip/snwh/appgrid-regression-fixes] workspacesView: Disable workspace switching while in search
- From: Sam Hewitt <snwh src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/snwh/appgrid-regression-fixes] workspacesView: Disable workspace switching while in search
- Date: Mon, 21 Feb 2022 19:27:36 +0000 (UTC)
commit e58f885e741835a0ef6b92f6cede6a965756c896
Author: Sebastian Keller <skeller gnome org>
Date: Sun Feb 20 16:53:43 2022 +0100
workspacesView: Disable workspace switching while in search
WorkspacesDisplay connects to key-press-event on the stage to switch
workspaces when page up or down is pressed and nothing else intercepts
these keys. This means that it is still possible to switch workspaces
while they are hidden behind the search.
So only allow these keybinding while the WorkspacesDisplay is reactive
which gets updated by ControlsManager depending on whether there is an
active search or not. Also set it as initially reactive, because
otherwise the keybindings would only work after performing an initial
search.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2204>
js/ui/workspacesView.js | 4 ++++
1 file changed, 4 insertions(+)
---
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index 6dad2df3f5..0acc3e5620 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -833,6 +833,7 @@ class WorkspacesDisplay extends St.Widget {
_init(controls, scrollAdjustment, overviewAdjustment) {
super._init({
layout_manager: new Clutter.BinLayout(),
+ reactive: true,
});
this._controls = controls;
@@ -1150,6 +1151,9 @@ class WorkspacesDisplay extends St.Widget {
if (this._overviewAdjustment.value !== ControlsState.WINDOW_PICKER)
return Clutter.EVENT_PROPAGATE;
+ if (!this.reactive)
+ return Clutter.EVENT_PROPAGATE;
+
const { workspaceManager } = global;
const vertical = workspaceManager.layout_rows === -1;
const rtl = this.get_text_direction() === Clutter.TextDirection.RTL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]