[gnome-shell] appDisplay: Remove leftover code from the spring animation

[Marge Bot <marge-bot src gnome org>]

commit e21b4ad04a27b36c7d97bb29cf7a890f196ebdc7
Author: Sebastian Keller <skeller gnome org>
Date:   Sat Jan 1 19:12:19 2022 +0100

    appDisplay: Remove leftover code from the spring animation
    
    These are some leftovers from when the shell stopped using the spring
    animation in 40.
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2081>

 js/ui/appDisplay.js | 31 +++----------------------------
 1 file changed, 3 insertions(+), 28 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 35fbfe49b6..df8acbf7bd 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1,8 +1,9 @@
 // -*- mode: js; js-indent-level: 4; indent-tabs-mode: nil -*-
 /* exported AppDisplay, AppSearchProvider */
 
-const { Clutter, Gio, GLib, GObject, Graphene, Meta,
-    Pango, Shell, St } = imports.gi;
+const {
+    Clutter, Gio, GLib, GObject, Graphene, Pango, Shell, St,
+} = imports.gi;
 
 const AppFavorites = imports.ui.appFavorites;
 const { AppMenu } = imports.ui.appMenu;
@@ -298,10 +299,6 @@ var BaseAppView = GObject.registerClass({
         this._items = new Map();
         this._orderedItems = [];
 
-        this._animateLaterId = 0;
-        this._viewLoadedHandlerId = 0;
-        this._viewIsReady = false;
-
         // Filter the apps through the user’s parental controls.
         this._parentalControlsManager = ParentalControlsManager.getDefault();
         this._appFilterChangedId =
@@ -858,7 +855,6 @@ var BaseAppView = GObject.registerClass({
                 this._moveItem(icon, page, position);
         });
 
-        this._viewIsReady = true;
         this.emit('view-loaded');
     }
 
@@ -901,24 +897,6 @@ var BaseAppView = GObject.registerClass({
         }
     }
 
-    _doSpringAnimation(animationDirection) {
-        this._grid.opacity = 255;
-        this._grid.animateSpring(
-            animationDirection,
-            Main.overview.dash.showAppsButton);
-    }
-
-    _clearAnimateLater() {
-        if (this._animateLaterId) {
-            Meta.later_remove(this._animateLaterId);
-            this._animateLaterId = 0;
-        }
-        if (this._viewLoadedHandlerId) {
-            this.disconnect(this._viewLoadedHandlerId);
-            this._viewLoadedHandlerId = 0;
-        }
-    }
-
     _getDropTarget(x, y, source) {
         const { currentPage } = this._grid;
 
@@ -1003,7 +981,6 @@ var BaseAppView = GObject.registerClass({
 
     vfunc_unmap() {
         this._swipeTracker.enabled = false;
-        this._clearAnimateLater();
         this._disconnectDnD();
         super.vfunc_unmap();
     }
@@ -1406,12 +1383,10 @@ class AppDisplay extends BaseAppView {
         this._redisplayWorkId = Main.initializeDeferredWork(this, this._redisplay.bind(this));
 
         Shell.AppSystem.get_default().connect('installed-changed', () => {
-            this._viewIsReady = false;
             Main.queueDeferredWork(this._redisplayWorkId);
         });
         this._folderSettings = new Gio.Settings({ schema_id: 'org.gnome.desktop.app-folders' });
         this._folderSettings.connect('changed::folder-children', () => {
-            this._viewIsReady = false;
             Main.queueDeferredWork(this._redisplayWorkId);
         });
     }