[gnome-bluetooth/wip/hadess/test-fix: 1/2] tests: Make test easier to understand
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-bluetooth/wip/hadess/test-fix: 1/2] tests: Make test easier to understand
- Date: Wed, 5 Jan 2022 13:13:29 +0000 (UTC)
commit 701edabd2a00a4a12d84e17db1cef7aa62495b54
Author: Bastien Nocera <hadess hadess net>
Date: Wed Jan 5 14:00:27 2022 +0100
tests: Make test easier to understand
Compare descriptive names rather than Bluetooth addresses to make the
tests easier to understand.
tests/integration-test | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
---
diff --git a/tests/integration-test b/tests/integration-test
index 97c0182e..9355bc87 100755
--- a/tests/integration-test
+++ b/tests/integration-test
@@ -204,7 +204,7 @@ class OopTests(dbusmock.DBusTestCase):
self.assertEqual(list_store.get_n_items(), 1)
device = list_store.get_item(0)
self.assertIsNotNone(device)
- self.assertEqual(device.props.address, '22:33:44:55:66:77')
+ self.assertEqual(device.props.name, 'Device on hci1')
# Set default adapter in setup mode
self.assertEqual (self.client.props.default_adapter_setup_mode, False)
@@ -224,16 +224,16 @@ class OopTests(dbusmock.DBusTestCase):
self.assertEqual(list_store.get_n_items(), 1)
device = list_store.get_item(0)
self.assertIsNotNone(device)
- self.assertEqual(device.props.address, '11:22:33:44:55:66')
+ self.assertEqual(device.props.name, 'Device on hci0')
# Re-add the old adapter, device is still there
- dbusmock_bluez.AddAdapter('hci1', 'my-computer #2')
+ dbusmock_bluez.AddAdapter('hci1', 'hci1')
# GListModel
self.assertEqual(list_store.get_n_items(), 1)
device = list_store.get_item(0)
self.assertIsNotNone(device)
- self.assertEqual(device.props.address, '11:22:33:44:55:66')
+ self.assertEqual(device.props.name, 'Device on hci0')
def test_default_adapter_powered(self):
bus = dbus.SystemBus()
@@ -410,10 +410,10 @@ class Tests(dbusmock.DBusTestCase):
self.run_test_process()
def test_default_adapter(self):
- self.dbusmock_bluez.AddAdapter('hci0', 'my-computer')
- self.dbusmock_bluez.AddAdapter('hci1', 'my-computer #2')
- self.dbusmock_bluez.AddDevice('hci0', '11:22:33:44:55:66', 'My Phone')
- self.dbusmock_bluez.AddDevice('hci1', '22:33:44:55:66:77', 'My Mouse')
+ self.dbusmock_bluez.AddAdapter('hci0', 'hci0')
+ self.dbusmock_bluez.AddAdapter('hci1', 'hci1')
+ self.dbusmock_bluez.AddDevice('hci0', '11:22:33:44:55:66', 'Device on hci0')
+ self.dbusmock_bluez.AddDevice('hci1', '22:33:44:55:66:77', 'Device on hci1')
self.run_test_process()
def test_default_adapter_powered(self):
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]