[glib-networking] openssl: explicitly NULL initialize PKCS8_PRIV_KEY_INFO
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib-networking] openssl: explicitly NULL initialize PKCS8_PRIV_KEY_INFO
- Date: Fri, 7 Jan 2022 15:01:11 +0000 (UTC)
commit 37d7c6af7cd54e440cf92547714ce4d47b5b6550
Author: Daniel Kolesa <daniel octaforge org>
Date: Fri Jan 7 06:47:04 2022 +0100
openssl: explicitly NULL initialize PKCS8_PRIV_KEY_INFO
Otherwise, PKCS8_PRIV_KEY_INFO_free will be called on an
uninitialized value if `!openssl->key` is true.
This results in WebKit TLS being broken at least with OpenSSL 3.x
and libsoup3.
Part-of: <https://gitlab.gnome.org/GNOME/glib-networking/-/merge_requests/201>
tls/openssl/gtlscertificate-openssl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/tls/openssl/gtlscertificate-openssl.c b/tls/openssl/gtlscertificate-openssl.c
index 2e3148c2..0bc7ea66 100644
--- a/tls/openssl/gtlscertificate-openssl.c
+++ b/tls/openssl/gtlscertificate-openssl.c
@@ -144,7 +144,7 @@ export_privkey_to_der (GTlsCertificateOpenssl *openssl,
guint8 **output_data,
long *output_size)
{
- PKCS8_PRIV_KEY_INFO *pkcs8;
+ PKCS8_PRIV_KEY_INFO *pkcs8 = NULL;
BIO *bio = NULL;
const guint8 *data;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]