[gnome-session/make-nologin-fail: 54/54] gnome-session: don't validate shell before using it




commit db1a97c2ffa091a37087cad15c759554e6fbb4ad
Author: Ray Strode <rstrode redhat com>
Date:   Tue Nov 19 09:29:16 2019 -0500

    gnome-session: don't validate shell before using it
    
    Users sometimes set their shell to an invalid shell to prevent
    login from proceeding.
    
    GNOME on Wayland still allows login in these cases.
    
    This commit makes the behavior match expectations by skipping
    shell validity checks when deciding to run though a login shell.

 gnome-session/gnome-session.in | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/gnome-session/gnome-session.in b/gnome-session/gnome-session.in
index ddd1a591..b4b1f8fa 100755
--- a/gnome-session/gnome-session.in
+++ b/gnome-session/gnome-session.in
@@ -2,10 +2,7 @@
 
 if [ "x$XDG_SESSION_TYPE" = "xwayland" ] &&
    [ "x$XDG_SESSION_CLASS" != "xgreeter" ] &&
-   [  -n "$SHELL" ] &&
-   grep -q "$SHELL" /etc/shells &&
-   ! (echo "$SHELL" | grep -q "false") &&
-   ! (echo "$SHELL" | grep -q "nologin"); then
+   [  -n "$SHELL" ]; then
   if [ "$1" != '-l' ]; then
     exec bash -c "exec -l '$SHELL' -c '$0 -l $*'"
   else


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]