[gnome-control-center] display: Always show refresh rate
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center] display: Always show refresh rate
- Date: Wed, 19 Jan 2022 00:54:02 +0000 (UTC)
commit 375bbc333c7939b6ea1612fb4485010931eec36c
Author: Robert Mader <robert mader posteo de>
Date: Thu Jan 6 22:00:52 2022 +0100
display: Always show refresh rate
Refresh rates are an important information for users, even if they
can't change them.
This is especially true for cases where knowledge of the refresh
rate may influence the decission about the resolution to use.
Consider the example where a display may support `3840x2160@60Hz`
and `2560x1440@144Hz`. When choosing `3840x2160` as resolution,
the refresh rate will likely get hidden, making the user unaware
of the fact that they will maybe not get what they want (potentially
144Hz).
So follow the example of e.g. the sound panel where input and output
devices are listed in dropdowns, even if they are the only options
selectable.
Note: while this is a design change, for a big group of users this
won't actually change the default experience as Mutter until recently
had a bug to duplicate 60Hz modes in many cases. So most laptop users
already saw the refresh rate panel in previous Gnome versions,
dispite it having little use.
See also:
https://gitlab.gnome.org/GNOME/mutter/-/commit/fb9564b87b9fe8ebc5a19c20dbfe036995d0dbad
panels/display/cc-display-settings.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
---
diff --git a/panels/display/cc-display-settings.c b/panels/display/cc-display-settings.c
index fe26fd32b..54301b30a 100644
--- a/panels/display/cc-display-settings.c
+++ b/panels/display/cc-display-settings.c
@@ -354,9 +354,7 @@ cc_display_settings_rebuild_ui (CcDisplaySettings *self)
adw_combo_row_set_selected (ADW_COMBO_ROW (self->refresh_rate_row), new);
}
- /* Show if we have more than one frequency to choose from. */
- gtk_widget_set_visible (self->refresh_rate_row,
- g_list_model_get_n_items (G_LIST_MODEL (self->refresh_rate_list)) > 1);
+ gtk_widget_set_visible (self->refresh_rate_row, TRUE);
}
else
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]