[orca] Script Manager: Handle apps going defunct during cleanup; more debugging
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Script Manager: Handle apps going defunct during cleanup; more debugging
- Date: Wed, 19 Jan 2022 11:46:18 +0000 (UTC)
commit 6580a8928bea2f8689627a7892165bb5e85da827
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Wed Jan 19 12:44:33 2022 +0100
Script Manager: Handle apps going defunct during cleanup; more debugging
src/orca/script_manager.py | 21 ++++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)
---
diff --git a/src/orca/script_manager.py b/src/orca/script_manager.py
index f01654705..a3fb55b50 100644
--- a/src/orca/script_manager.py
+++ b/src/orca/script_manager.py
@@ -340,7 +340,10 @@ class ScriptManager:
def _pid(app):
try:
- return app.get_process_id()
+ result = app.get_process_id()
+ msg = "SCRIPT MANAGER: %s is has pid: %s" % (app, result)
+ debug.println(debug.LEVEL_INFO, msg, True)
+ return result
except:
msg = "SCRIPT MANAGER: Exception getting pid for %s" % app
debug.println(debug.LEVEL_INFO, msg, True)
@@ -348,7 +351,10 @@ class ScriptManager:
def _isValidApp(app):
try:
- return a in self._desktop
+ result = app in self._desktop
+ msg = "SCRIPT MANAGER: %s is in desktop: %s" % (app, result)
+ debug.println(debug.LEVEL_INFO, msg, True)
+ return result
except:
msg = "SCRIPT MANAGER: Exception seeing if %s is in desktop" % app
debug.println(debug.LEVEL_INFO, msg, True)
@@ -381,7 +387,16 @@ class ScriptManager:
msg = "SCRIPT MANAGER: %s is no longer in registry's desktop" % app
debug.println(debug.LEVEL_INFO, msg, True)
- appScript = self.appScripts.pop(app)
+ try:
+ appScript = self.appScripts.pop(app)
+ except KeyError:
+ msg = "SCRIPT MANAGER: %s not found in appScripts" % app
+ debug.println(debug.LEVEL_INFO, msg, True)
+ continue
+
+ msg = "SCRIPT MANAGER: Old script for app found: %s" % appScript
+ debug.println(debug.LEVEL_INFO, msg, True)
+
newScript = self._getScriptForAppReplicant(app)
if newScript:
msg = "SCRIPT MANAGER: Script for app replicant found: %s" % newScript
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]