[gupnp] ServiceProxy: Use send_async
- From: Jens Georg <jensgeorg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gupnp] ServiceProxy: Use send_async
- Date: Sun, 23 Jan 2022 15:17:16 +0000 (UTC)
commit ab7a596be3f17a06b6c7a1c3a4de775b81526c1c
Author: Jens Georg <mail jensge org>
Date: Sun Jan 23 16:10:46 2022 +0100
ServiceProxy: Use send_async
So we skip needlessly reading in the message body
libgupnp/gupnp-service-proxy.c | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
---
diff --git a/libgupnp/gupnp-service-proxy.c b/libgupnp/gupnp-service-proxy.c
index 82b1393..a022619 100644
--- a/libgupnp/gupnp-service-proxy.c
+++ b/libgupnp/gupnp-service-proxy.c
@@ -1134,12 +1134,8 @@ subscribe_got_response (GObject *source, GAsyncResult *res, gpointer user_data)
priv = gupnp_service_proxy_get_instance_private (data->proxy);
- GBytes *body = soup_session_send_and_read_finish (SOUP_SESSION (source),
- res,
- &error);
-
- // We don't need the body, it should be empty anyway
- g_clear_pointer (&body, g_bytes_unref);
+ GInputStream *is =
+ soup_session_send_finish (SOUP_SESSION (source), res, &error);
/* Cancelled? */
if (g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED)) {
@@ -1149,6 +1145,8 @@ subscribe_got_response (GObject *source, GAsyncResult *res, gpointer user_data)
goto hdr_err;
}
+ // We don't need the body, it should be empty anyway
+ g_input_stream_close (is, NULL, NULL);
/* Remove subscription timeout */
g_clear_pointer (&priv->subscription_timeout_src, g_source_destroy);
@@ -1360,12 +1358,12 @@ subscribe (GUPnPServiceProxy *proxy)
data->msg = msg;
data->proxy = proxy;
- soup_session_send_and_read_async (session,
- msg,
- G_PRIORITY_DEFAULT,
- priv->pending_messages,
- subscribe_got_response,
- data);
+ soup_session_send_async (session,
+ msg,
+ G_PRIORITY_DEFAULT,
+ priv->pending_messages,
+ subscribe_got_response,
+ data);
}
/*
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]