[totem/wip/hadess/glsink-preparation: 4/4] screenshot: Always show an error
- From: Bastien Nocera <hadess src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [totem/wip/hadess/glsink-preparation: 4/4] screenshot: Always show an error
- Date: Thu, 27 Jan 2022 11:44:32 +0000 (UTC)
commit 8a94f122e7ee21c90d626ffba5d948a0763e4967
Author: Bastien Nocera <hadess hadess net>
Date: Wed Jan 26 12:10:14 2022 +0100
screenshot: Always show an error
Show an error if bacon_video_widget_can_get_frames() failed, even if it
didn't return a GError.
src/plugins/screenshot/totem-screenshot-plugin.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/src/plugins/screenshot/totem-screenshot-plugin.c
b/src/plugins/screenshot/totem-screenshot-plugin.c
index 2754b1851..43cb24146 100644
--- a/src/plugins/screenshot/totem-screenshot-plugin.c
+++ b/src/plugins/screenshot/totem-screenshot-plugin.c
@@ -218,10 +218,7 @@ take_screenshot_action_cb (GSimpleAction *action,
g_autofree char *escaped_video_name = NULL;
if (bacon_video_widget_can_get_frames (priv->bvw, &err) == FALSE) {
- if (err == NULL)
- return;
-
- totem_object_show_error (priv->totem, _("Totem could not get a screenshot of the video."),
err->message);
+ totem_object_show_error (priv->totem, _("Totem could not get a screenshot of the video."),
err->message ?: _("No reason."));
g_error_free (err);
return;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]