[file-roller/wip/jtojnar/extract-crash] extract: Fix crash when extracting to tmpfs




commit 7241cd37ef6e470ed75326cb57765ab13345dcf0
Author: Jan Tojnar <jtojnar gmail com>
Date:   Fri Jul 1 22:14:43 2022 +0200

    extract: Fix crash when extracting to tmpfs
    
    https://gitlab.gnome.org/GNOME/file-roller/-/commit/d85be7077b23de550b418cba6fe08bf74fd276ef introduced a 
race between destroying the dialog (which frees the destination path) and extracting the files.
    
    Fixes: https://gitlab.gnome.org/GNOME/file-roller/-/issues/160

 src/dlg-extract.c | 2 ++
 1 file changed, 2 insertions(+)
---
diff --git a/src/dlg-extract.c b/src/dlg-extract.c
index f340e185..c754b116 100644
--- a/src/dlg-extract.c
+++ b/src/dlg-extract.c
@@ -259,6 +259,7 @@ extract_cb_start_extracting (DialogData *data)
 
        /* close the dialog. */
 
+       data->destination = NULL; /* do not free when destroying the dialog. */
        gtk_widget_destroy (data->dialog);
 
        /* extract ! */
@@ -273,6 +274,7 @@ extract_cb_start_extracting (DialogData *data)
 
        _g_string_list_free (file_list);
        g_free (base_dir);
+       g_object_unref (destination);
 }
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]