[nautilus/wip/cdavis/post-port-cleanups: 9/14] grid-view: Don't set `focusable`
- From: António Fernandes <antoniof src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus/wip/cdavis/post-port-cleanups: 9/14] grid-view: Don't set `focusable`
- Date: Sat, 16 Jul 2022 19:02:28 +0000 (UTC)
commit 5fe9df1a3906e707f59e3b2aafb16ac8b4d6c55d
Author: Christopher Davis <christopherdavis gnome org>
Date: Sat Jul 16 08:02:11 2022 -0400
grid-view: Don't set `focusable`
The view can receive focus, which causes it to draw an unnecessary
ring when focused and requires an extra focus step to get into the
items.
The view itself should not be focusable. This was set as a translation
of `can-focus`, but the semantics are different, and you generally
don't want to manually set `focusable` as the widgets set proper
defaults.
src/nautilus-grid-view.c | 2 --
1 file changed, 2 deletions(-)
---
diff --git a/src/nautilus-grid-view.c b/src/nautilus-grid-view.c
index 1d91d1b92..74a80e1f5 100644
--- a/src/nautilus-grid-view.c
+++ b/src/nautilus-grid-view.c
@@ -411,8 +411,6 @@ create_view_ui (NautilusGridView *self)
g_signal_connect (factory, "unbind", G_CALLBACK (unbind_cell), self);
widget = gtk_grid_view_new (GTK_SELECTION_MODEL (model), factory);
- gtk_widget_set_focusable (widget, TRUE);
-
/* We don't use the built-in child activation feature for clicks because it
* doesn't fill all our needs nor does it match our expected behavior.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]