[glib/gobject-speedup4: 1/2] Don't inline deprecation warnings




commit 3ad0826744abda31d1f92d54ef0c5b5836a17aab
Author: Matthias Clasen <mclasen redhat com>
Date:   Wed Sep 29 01:38:43 2021 -0400

    Don't inline deprecation warnings
    
    The code that emits property deprecation warnings
    rarely runs, and doesn't need to be inlined
    everywhere. It is enough to inline the check for
    the deprecation flag.

 gobject/gobject.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
---
diff --git a/gobject/gobject.c b/gobject/gobject.c
index 4b437be15f..58b7e99a73 100644
--- a/gobject/gobject.c
+++ b/gobject/gobject.c
@@ -1505,16 +1505,13 @@ g_object_thaw_notify (GObject *object)
 }
 
 static void
-consider_issuing_property_deprecation_warning (const GParamSpec *pspec)
+maybe_issue_property_deprecation_warning (const GParamSpec *pspec)
 {
   static GHashTable *already_warned_table;
   static const gchar *enable_diagnostic;
   static GMutex already_warned_lock;
   gboolean already;
 
-  if (!(pspec->flags & G_PARAM_DEPRECATED))
-    return;
-
   if (g_once_init_enter (&enable_diagnostic))
     {
       const gchar *value = g_getenv ("G_ENABLE_DIAGNOSTIC");
@@ -1554,6 +1551,13 @@ consider_issuing_property_deprecation_warning (const GParamSpec *pspec)
                g_type_name (pspec->owner_type), pspec->name);
 }
 
+static inline void
+consider_issuing_property_deprecation_warning (const GParamSpec *pspec)
+{
+  if (G_UNLIKELY (pspec->flags & G_PARAM_DEPRECATED))
+    maybe_issue_property_deprecation_warning (pspec);
+}
+
 static inline void
 object_get_property (GObject     *object,
                     GParamSpec  *pspec,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]