[epiphany/gnome-42] reader-handler: fix double free of error
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/gnome-42] reader-handler: fix double free of error
- Date: Tue, 1 Mar 2022 13:54:21 +0000 (UTC)
commit 661444641798ae4312cac8cac31a47748a62bb02
Author: Michael Catanzaro <mcatanzaro redhat com>
Date: Mon Feb 28 12:43:15 2022 -0600
reader-handler: fix double free of error
When the reader mode JS fails, we accidentally free it manually, even
though it's stored in an autoptr. Oops!
Fixes #1698, sort of. This really only fixes the Epiphany side of
things. I will report a separate WebKit bug to ensure the JS execution
never fails.
Part-of: <https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1084>
(cherry picked from commit 4d6819e9382dd799b8379fea8a6f4444e692ead4)
embed/ephy-reader-handler.c | 1 -
1 file changed, 1 deletion(-)
---
diff --git a/embed/ephy-reader-handler.c b/embed/ephy-reader-handler.c
index 304a1854d..aa2c8dfe3 100644
--- a/embed/ephy-reader-handler.c
+++ b/embed/ephy-reader-handler.c
@@ -172,7 +172,6 @@ readability_js_finish_cb (GObject *object,
if (!js_result) {
if (!g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED))
g_warning ("Error running javascript: %s", error->message);
- g_error_free (error);
return;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]