[gnome-software/1584-app-details-loading-page-drop-title] gs-details-page: Drop 'Loading...' title from the window header
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [gnome-software/1584-app-details-loading-page-drop-title] gs-details-page: Drop 'Loading...' title from the window header
- Date: Thu,  3 Mar 2022 14:32:02 +0000 (UTC)
commit c917f2c4272d383e92831c8c95ee52966854d943
Author: Milan Crha <mcrha redhat com>
Date:   Thu Mar 3 15:30:15 2022 +0100
    gs-details-page: Drop 'Loading...' title from the window header
    
    The 'Loading...' is already shown within the window body, no need
    to repeat it in the window title/header.
    
    Closes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1584
 src/gs-details-page.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index b9f5c1e03..9d0f7352b 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -2072,9 +2072,8 @@ gs_details_page_get_property (GObject    *object,
        case PROP_TITLE:
                switch (gs_details_page_get_state (self)) {
                case GS_DETAILS_PAGE_STATE_LOADING:
-                       /* TRANSLATORS: This is a title for the app details page,
-                        * shown when it’s loading the details of an app. */
-                       g_value_set_string (value, _("Loading…"));
+                       /* 'Loading' is shown in the page already, no need to repeat it in the title */
+                       g_value_set_string (value, NULL);
                        break;
                case GS_DETAILS_PAGE_STATE_READY:
                        g_value_set_string (value, gs_app_get_name (self->app));
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]