[gnome-shell/wip/carlosg/no-event-source: 15/19] searchController: Query stage for target actor instead of event.get_source()
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/carlosg/no-event-source: 15/19] searchController: Query stage for target actor instead of event.get_source()
- Date: Fri, 4 Mar 2022 12:27:38 +0000 (UTC)
commit dc0f286fe9660a845b0d299545cc74b30f87d0d7
Author: Carlos Garnacho <carlosg gnome org>
Date: Fri Feb 25 13:10:30 2022 +0100
searchController: Query stage for target actor instead of event.get_source()
Events are going to stop containing the destinatary, so stop using this
API. Querying the stage is equivalent and ensured to be up-to-date.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2216>
js/ui/searchController.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/js/ui/searchController.js b/js/ui/searchController.js
index 5d25897c79..ac22439a44 100644
--- a/js/ui/searchController.js
+++ b/js/ui/searchController.js
@@ -306,12 +306,12 @@ var SearchController = GObject.registerClass({
_onCapturedEvent(actor, event) {
if (event.type() === Clutter.EventType.BUTTON_PRESS) {
- let source = event.get_source();
- if (source !== this._text &&
+ const targetActor = global.stage.get_event_actor(event);
+ if (targetActor !== this._text &&
this._text.has_key_focus() &&
this._text.text === '' &&
!this._text.has_preedit() &&
- !Main.layoutManager.keyboardBox.contains(source)) {
+ !Main.layoutManager.keyboardBox.contains(targetActor)) {
// the user clicked outside after activating the entry, but
// with no search term entered and no keyboard button pressed
// - cancel the search
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]