[gnome-shell/wip/carlosg/no-event-source: 16/19] searchController: Avoid event.set_source() API
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/carlosg/no-event-source: 16/19] searchController: Avoid event.set_source() API
- Date: Fri, 4 Mar 2022 12:27:38 +0000 (UTC)
commit 6d895bf8a9faff0b176f024de3df6b018d34fae7
Author: Carlos Garnacho <carlosg gnome org>
Date: Fri Feb 25 13:10:53 2022 +0100
searchController: Avoid event.set_source() API
It does not make sense that the target actor is both destinatary
and content of the events being sent, so this API call is going away.
Since the event can be sent entirely unmodified (more so, it will
become immutable/readonly in the future), avoid creating a copy
since it does not matter sending one or other struct.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2216>
js/ui/searchController.js | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/js/ui/searchController.js b/js/ui/searchController.js
index ac22439a44..ba743a9094 100644
--- a/js/ui/searchController.js
+++ b/js/ui/searchController.js
@@ -228,10 +228,7 @@ var SearchController = GObject.registerClass({
startSearch(event) {
global.stage.set_key_focus(this._text);
-
- let synthEvent = event.copy();
- synthEvent.set_source(this._text);
- this._text.event(synthEvent, false);
+ this._text.event(event, false);
}
// the entry does not show the hint
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]