[gnome-commander/gcmd-1-14] Fix of size comparison: use correct getter method for G_FILE_ATTRIBUTE_STANDARD_SIZE, fixing #121



commit 5694d612916f25871d769ff09a79e606d089b3b4
Author: Uwe Scholz <u scholz83 gmx de>
Date:   Sun Mar 20 17:28:22 2022 +0100

    Fix of size comparison: use correct getter method for G_FILE_ATTRIBUTE_STANDARD_SIZE, fixing #121

 data/org.gnome.gnome-commander.appdata.xml.in | 2 +-
 src/gnome-cmd-file-list.cc                    | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/data/org.gnome.gnome-commander.appdata.xml.in b/data/org.gnome.gnome-commander.appdata.xml.in
index eeef9086..8abcaa56 100644
--- a/data/org.gnome.gnome-commander.appdata.xml.in
+++ b/data/org.gnome.gnome-commander.appdata.xml.in
@@ -63,7 +63,7 @@
       <description>
         <p>This release fixes the following bugs:</p>
         <ul>
-          <li>...</li>
+          <li>Issue #121: File sorting by size fails</li>
         </ul>
         <p>New or updated translations: ...</p>
         <p>New or updated docs: ...</p>
diff --git a/src/gnome-cmd-file-list.cc b/src/gnome-cmd-file-list.cc
index cccac8ee..93d17068 100644
--- a/src/gnome-cmd-file-list.cc
+++ b/src/gnome-cmd-file-list.cc
@@ -1033,8 +1033,9 @@ static gint sort_by_size (GnomeCmdFile *f1, GnomeCmdFile *f2, GnomeCmdFileList *
 
     if (!ret)
     {
-        ret = my_filesizecmp (f1->GetGfileAttributeUInt32(G_FILE_ATTRIBUTE_STANDARD_SIZE),
-                              f2->GetGfileAttributeUInt32(G_FILE_ATTRIBUTE_STANDARD_SIZE), raising);
+        ret = my_filesizecmp (f1->GetGfileAttributeUInt64(G_FILE_ATTRIBUTE_STANDARD_SIZE),
+                              f2->GetGfileAttributeUInt64(G_FILE_ATTRIBUTE_STANDARD_SIZE), raising);
+
         if (!ret)
             ret = my_strcmp (f1->get_collation_fname(), f2->get_collation_fname(), file_raising);
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]