[libsoup/mcatanzaro/#184: 3/3] negotiate: add warning comment about something that doesn't look right
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libsoup/mcatanzaro/#184: 3/3] negotiate: add warning comment about something that doesn't look right
- Date: Wed, 4 May 2022 21:06:11 +0000 (UTC)
commit 21d1170354cb84241ed738dc5c2b4db5f68ccf3b
Author: Michael Catanzaro <mcatanzaro redhat com>
Date: Wed May 4 16:01:20 2022 -0500
negotiate: add warning comment about something that doesn't look right
I do not understand this code, but I have a suspicion that something is
not right.
libsoup/auth/soup-auth-negotiate.c | 4 ++++
1 file changed, 4 insertions(+)
---
diff --git a/libsoup/auth/soup-auth-negotiate.c b/libsoup/auth/soup-auth-negotiate.c
index d39bb69e..1f122912 100644
--- a/libsoup/auth/soup-auth-negotiate.c
+++ b/libsoup/auth/soup-auth-negotiate.c
@@ -355,6 +355,10 @@ check_server_response (SoupMessage *msg, gpointer auth)
if (auth != soup_message_get_auth (msg))
return;
+ /* XXX: If we get 401 Unauthorized, we're supposed to keep processing
+ * the authentication data. Why do we return early here? This seems
+ * wrong?
+ */
if (soup_message_get_status (msg) == SOUP_STATUS_UNAUTHORIZED)
return;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]