[gimp/gimp-2-10] Cppcheck fixes

[Jacob Boerema <jboerema src gnome org>]

commit bfc59da987f76b24a0444ac416a1f8abef48b2c8
Author: Rafał Mikrut <mikrutrafal54 gmail com>
Date:   Tue Nov 3 06:35:54 2020 +0100

    Cppcheck fixes
    
    (cherry picked from commit 3e35fe4d80bbbaa86e85bd127a07fce2c55f3c6c)
    
    # Conflicts:
    #       app/widgets/gimpcolordialog.c
    #       libgimpwidgets/gimpchainbutton.c

 app/widgets/gimpspinscale.c | 2 +-
 plug-ins/file-fli/fli.c     | 4 ++--
 plug-ins/gfig/gfig-circle.c | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/app/widgets/gimpspinscale.c b/app/widgets/gimpspinscale.c
index 7fa4039bed..343dc88938 100644
--- a/app/widgets/gimpspinscale.c
+++ b/app/widgets/gimpspinscale.c
@@ -382,7 +382,7 @@ pattern_to_attrs (const gchar *text,
 
   while (TRUE)
     {
-      while (*p && *q && *q != '_')
+      while (*p && q && *q != '_')
         {
           p = g_utf8_next_char (p);
           q++;
diff --git a/plug-ins/file-fli/fli.c b/plug-ins/file-fli/fli.c
index d5400cfdd1..c2e28e4fc4 100644
--- a/plug-ins/file-fli/fli.c
+++ b/plug-ins/file-fli/fli.c
@@ -884,8 +884,8 @@ fli_write_lc (FILE          *f,
       while (xc < fli_header->width)
         {
           sc = 0;
-          while ((linebuf[xc] == old_linebuf[xc]) &&
-                 (xc < fli_header->width)         &&
+          while ((xc < fli_header->width)         &&
+                 (linebuf[xc] == old_linebuf[xc]) &&
                  (sc < 255))
             {
               xc++;
diff --git a/plug-ins/gfig/gfig-circle.c b/plug-ins/gfig/gfig-circle.c
index e3b779597b..0839abfc8e 100644
--- a/plug-ins/gfig/gfig-circle.c
+++ b/plug-ins/gfig/gfig-circle.c
@@ -147,7 +147,7 @@ d_paint_circle (GfigObject *obj)
       gdouble       angle = 0;
       gint          i = 0;
 
-      while (i < 362)
+      while (i < 361)
         {
           static const gdouble step = 2 * G_PI / 180;