[fractal] chore: Remove outdated TODOs
- From: Julian Sparber <jsparber src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [fractal] chore: Remove outdated TODOs
- Date: Fri, 20 May 2022 11:12:30 +0000 (UTC)
commit ed81277a8a2273720d0e1bbb672fee333ca56d6d
Author: Kévin Commaille <zecakeh tedomum fr>
Date: Fri May 20 11:17:21 2022 +0200
chore: Remove outdated TODOs
src/session/content/invite.rs | 1 -
src/session/content/room_history/item_row.rs | 2 --
src/session/content/room_history/message_row/mod.rs | 5 -----
src/session/content/room_history/state_row/mod.rs | 2 --
4 files changed, 10 deletions(-)
---
diff --git a/src/session/content/invite.rs b/src/session/content/invite.rs
index 47a4eb59c..f81b9a433 100644
--- a/src/session/content/invite.rs
+++ b/src/session/content/invite.rs
@@ -178,7 +178,6 @@ impl Invite {
}
}
- // FIXME: remove closure when room changes
if let Some(ref room) = room {
let handler_id = room.connect_notify_local(
Some("category"),
diff --git a/src/session/content/room_history/item_row.rs b/src/session/content/room_history/item_row.rs
index 2354d452b..62c140198 100644
--- a/src/session/content/room_history/item_row.rs
+++ b/src/session/content/room_history/item_row.rs
@@ -151,8 +151,6 @@ glib::wrapper! {
@extends gtk::Widget, adw::Bin, ContextMenuBin, @implements gtk::Accessible;
}
-// TODO:
-// - [ ] Don't show rows for items that don't have a visible UI
impl ItemRow {
pub fn new(room_history: &RoomHistory) -> Self {
glib::Object::new(&[("room-history", room_history)]).expect("Failed to create ItemRow")
diff --git a/src/session/content/room_history/message_row/mod.rs
b/src/session/content/room_history/message_row/mod.rs
index 864a97e7c..235b52fc9 100644
--- a/src/session/content/room_history/message_row/mod.rs
+++ b/src/session/content/room_history/message_row/mod.rs
@@ -119,8 +119,6 @@ glib::wrapper! {
@extends gtk::Widget, adw::Bin, @implements gtk::Accessible;
}
-// TODO
-// - [] Implement widgets to show message events
impl MessageRow {
pub fn new() -> Self {
glib::Object::new(&[]).expect("Failed to create MessageRow")
@@ -233,9 +231,6 @@ impl Default for MessageRow {
/// If `compact` is true, the content should appear in a smaller format without
/// interactions, if possible.
fn build_content(parent: &adw::Bin, event: &Event, compact: bool) {
- // TODO: create widgets for all event types
- // TODO: display reaction events from event.relates_to()
- // TODO: we should reuse the already present child widgets when possible
match event.content() {
Some(AnyMessageLikeEventContent::RoomMessage(message)) => {
let msgtype = if let Some(Relation::Replacement(replacement)) = message.relates_to {
diff --git a/src/session/content/room_history/state_row/mod.rs
b/src/session/content/room_history/state_row/mod.rs
index 674e505f9..63e9d903c 100644
--- a/src/session/content/room_history/state_row/mod.rs
+++ b/src/session/content/room_history/state_row/mod.rs
@@ -49,8 +49,6 @@ glib::wrapper! {
@extends gtk::Widget, adw::Bin, @implements gtk::Accessible;
}
-// TODO
-// - [] Implement widgets to show state events
impl StateRow {
pub fn new() -> Self {
glib::Object::new(&[]).expect("Failed to create StateRow")
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]