[glib/gobject-speedups: 11/22] Don't inline deprecation warnings
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/gobject-speedups: 11/22] Don't inline deprecation warnings
- Date: Fri, 20 May 2022 11:44:14 +0000 (UTC)
commit 68beb5df047c14a6cfb9d9f656bc833190303644
Author: Matthias Clasen <mclasen redhat com>
Date: Wed Sep 29 01:38:43 2021 -0400
Don't inline deprecation warnings
The code that emits property deprecation warnings
rarely run, and doesn't need to be inlined in all
our property setters.
gobject/gobject.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
---
diff --git a/gobject/gobject.c b/gobject/gobject.c
index dadc557dbd..e579cd81da 100644
--- a/gobject/gobject.c
+++ b/gobject/gobject.c
@@ -1492,16 +1492,13 @@ g_object_thaw_notify (GObject *object)
}
static void
-consider_issuing_property_deprecation_warning (const GParamSpec *pspec)
+maybe_issue_property_deprecation_warning (const GParamSpec *pspec)
{
static GHashTable *already_warned_table;
static const gchar *enable_diagnostic;
static GMutex already_warned_lock;
gboolean already;
- if (!(pspec->flags & G_PARAM_DEPRECATED))
- return;
-
if (g_once_init_enter (&enable_diagnostic))
{
const gchar *value = g_getenv ("G_ENABLE_DIAGNOSTIC");
@@ -1541,6 +1538,13 @@ consider_issuing_property_deprecation_warning (const GParamSpec *pspec)
g_type_name (pspec->owner_type), pspec->name);
}
+static inline void
+consider_issuing_property_deprecation_warning (const GParamSpec *pspec)
+{
+ if (G_UNLIKELY (pspec->flags & G_PARAM_DEPRECATED))
+ maybe_issue_property_deprecation_warning (pspec);
+}
+
static inline void
object_get_property (GObject *object,
GParamSpec *pspec,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]