[glib/finalize-speedups2] gobject: Don't do duplicate work
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/finalize-speedups2] gobject: Don't do duplicate work
- Date: Mon, 23 May 2022 13:21:39 +0000 (UTC)
commit b1a6324466d614dcf6e140a0acf1a03e5b02787d
Author: Matthias Clasen <mclasen redhat com>
Date: Sun May 22 07:25:20 2022 -0400
gobject: Don't do duplicate work
We already remove the signal handlers and
weak refs in g_object_real_dispose. No need
to do it again after dispose, and before
the data is cleaned out for good in finalize.
gobject/gobject.c | 9 ---------
1 file changed, 9 deletions(-)
---
diff --git a/gobject/gobject.c b/gobject/gobject.c
index 4cb6ea2066..65cf02ca45 100644
--- a/gobject/gobject.c
+++ b/gobject/gobject.c
@@ -3682,15 +3682,6 @@ g_object_unref (gpointer _object)
}
/* we are still in the process of taking away the last ref */
- g_signal_handlers_destroy (object);
- {
- GQuark keys[3] = {
- quark_closure_array,
- quark_weak_refs,
- quark_weak_locations,
- };
- g_datalist_id_remove_multiple (&object->qdata, keys, G_N_ELEMENTS (keys));
- }
/* decrement the last reference */
old_ref = g_atomic_int_add (&object->ref_count, -1);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]