[gtk/blink-assertion-for-4-6] Remove an assertion that we hit
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/blink-assertion-for-4-6] Remove an assertion that we hit
- Date: Fri, 27 May 2022 11:06:40 +0000 (UTC)
commit 09a01512335e13014c9440c1aa5b11aaf42b1d30
Author: Matthias Clasen <mclasen redhat com>
Date: Mon May 23 08:28:00 2022 -0400
Remove an assertion that we hit
It appears that we mess up accounting for blinking
cursors sometimes, and can hit blink_cb when there
is a nonempty selection.
Instead of asserting, warn and stop blinking.
Related: #4767
gtk/gtktext.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
---
diff --git a/gtk/gtktext.c b/gtk/gtktext.c
index e8e1c51563..b8e15aa2d2 100644
--- a/gtk/gtktext.c
+++ b/gtk/gtktext.c
@@ -6571,7 +6571,13 @@ blink_cb (GtkWidget *widget,
return G_SOURCE_REMOVE;
}
- g_assert (priv->selection_bound == priv->current_pos);
+ if (priv->selection_bound != priv->current_pos)
+ {
+ g_warning ("GtkText - unexpected blinking selection. Removing");
+
+ gtk_text_check_cursor_blink (self);
+ return G_SOURCE_REMOVE;
+ }
blink_timeout = get_cursor_blink_timeout (self);
blink_time = get_cursor_time (self);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]