[glib/gobject-speedups] gobject: Avoid redundant atomics
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/gobject-speedups] gobject: Avoid redundant atomics
- Date: Sun, 29 May 2022 22:55:08 +0000 (UTC)
commit b0ec24c01230322730ec6a06619e0364339bc6d9
Author: Matthias Clasen <mclasen redhat com>
Date: Sun May 29 18:50:22 2022 -0400
gobject: Avoid redundant atomics
According to the commit that introduced these
calls (4b334ef8f1393c997a2d83d), we are checking
the refcount here to avoid calling g_object_ref
when the refcount is 0, in the rare case that
notification would be triggered during finalize.
But we are now freezing notifications during
finalize, and after recent changes, we no longer call
g_object_ref for notification while a freeze is
in place.
gobject/gobject.c | 5 -----
1 file changed, 5 deletions(-)
---
diff --git a/gobject/gobject.c b/gobject/gobject.c
index e90fc7b965..d5e426e434 100644
--- a/gobject/gobject.c
+++ b/gobject/gobject.c
@@ -1393,8 +1393,6 @@ g_object_notify (GObject *object,
g_return_if_fail (G_IS_OBJECT (object));
g_return_if_fail (property_name != NULL);
- if (g_atomic_int_get (&object->ref_count) == 0)
- return;
/* We don't need to get the redirect target
* (by, e.g. calling g_object_class_find_property())
@@ -1467,9 +1465,6 @@ g_object_notify_by_pspec (GObject *object,
g_return_if_fail (G_IS_OBJECT (object));
g_return_if_fail (G_IS_PARAM_SPEC (pspec));
- if (g_atomic_int_get (&object->ref_count) == 0)
- return;
-
g_object_notify_by_spec_internal (object, pspec);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]