[gnome-online-accounts/gnome-3-44] kerberos-identity-manager: Avoid a CRITICAL if an identity didn't renew



commit 66a27cd30a70004cb5c2104dd906fc83c801f218
Author: Debarshi Ray <debarshir gnome org>
Date:   Tue Oct 11 19:51:36 2022 +0200

    kerberos-identity-manager: Avoid a CRITICAL if an identity didn't renew
    
    The g_task_return_* API can't be used more than once on the same GTask
    instance.  Otherwise it will lead to:
      GLib-GIO-CRITICAL **: g_task_return_boolean: assertion
        '!task->ever_returned' failed
    
    Fallout from 4b538e064b20d53e7c294dbeef0cf0bce1beaaca
    
    https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/issues/160
    
    
    (cherry picked from commit 6c6183e6e743692220ca19c67389cf68ca4ccf0f)
    
    (cherry picked from commit 24dccca23ce080f4e4f18e17a84396e273432259)

 src/goaidentity/goakerberosidentitymanager.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/src/goaidentity/goakerberosidentitymanager.c b/src/goaidentity/goakerberosidentitymanager.c
index c35aa8b6..caed5ae2 100644
--- a/src/goaidentity/goakerberosidentitymanager.c
+++ b/src/goaidentity/goakerberosidentitymanager.c
@@ -706,6 +706,7 @@ renew_identity (GoaKerberosIdentityManager *self,
                error->message);
 
       g_task_return_error (operation->task, error);
+      return;
     }
 
   g_task_return_boolean (operation->task, was_renewed);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]