[gnome-online-accounts/gnome-43] kerberos-identity: Fail initialization if an identifier can't be found
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-online-accounts/gnome-43] kerberos-identity: Fail initialization if an identifier can't be found
- Date: Thu, 13 Oct 2022 20:28:21 +0000 (UTC)
commit d700565d1f0f166e431607531a4b68f3ce3b5ccd
Author: Debarshi Ray <debarshir gnome org>
Date: Thu Oct 13 22:14:07 2022 +0200
kerberos-identity: Fail initialization if an identifier can't be found
The inability to get an identifier already leads to an error.
Continuing beyond that point can lead to the verification_error trying
to clobber it.
https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/merge_requests/107
(cherry picked from commit 4acfcc323e986526975ede981673dd173be4e267)
src/goaidentity/goakerberosidentity.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/goaidentity/goakerberosidentity.c b/src/goaidentity/goakerberosidentity.c
index 45d54f4d..7d14536e 100644
--- a/src/goaidentity/goakerberosidentity.c
+++ b/src/goaidentity/goakerberosidentity.c
@@ -985,9 +985,10 @@ goa_kerberos_identity_initable_init (GInitable *initable,
if (self->identifier == NULL)
{
self->identifier = get_identifier (self, error);
+ if (self->identifier == NULL)
+ return FALSE;
- if (self->identifier != NULL)
- queue_notify (self, &self->identifier_idle_id, "identifier");
+ queue_notify (self, &self->identifier_idle_id, "identifier");
}
verification_error = NULL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]