[gnome-builder/wip/chergert/lsp-plugin-loader] libide/lsp: implement dynamic GType registration for formatters

[Christian Hergert <chergert src gnome org>]

commit ee94fe5d52fb5ff50bad50d7d3038be11918a609
Author: Christian Hergert <chergert redhat com>
Date:   Thu Oct 13 19:04:15 2022 -0500

    libide/lsp: implement dynamic GType registration for formatters

 src/libide/lsp/ide-lsp-plugin-formatter.c | 100 ++++++++++++++++++++++++++++++
 src/libide/lsp/ide-lsp-plugin-private.h   |   4 ++
 src/libide/lsp/ide-lsp-plugin.c           |  10 +--
 src/libide/lsp/meson.build                |   1 +
 4 files changed, 106 insertions(+), 9 deletions(-)
---
diff --git a/src/libide/lsp/ide-lsp-plugin-formatter.c b/src/libide/lsp/ide-lsp-plugin-formatter.c
new file mode 100644
index 000000000..5ec5d990b
--- /dev/null
+++ b/src/libide/lsp/ide-lsp-plugin-formatter.c
@@ -0,0 +1,100 @@
+/* ide-lsp-plugin-formatter.c
+ *
+ * Copyright 2022 Christian Hergert <chergert redhat com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+#define G_LOG_DOMAIN "ide-lsp-plugin-formatter"
+
+#include "config.h"
+
+#include <libpeas/peas.h>
+
+#include <libide-code.h>
+
+#include "ide-lsp-formatter.h"
+#include "ide-lsp-plugin-private.h"
+#include "ide-lsp-service.h"
+
+typedef struct _IdeLspPluginFormatterClass
+{
+  IdeLspFormatterClass  parent_class;
+  IdeLspPluginInfo     *info;
+} IdeLspPluginFormatterClass;
+
+static void
+ide_lsp_plugin_formatter_load (IdeFormatter *resolver)
+{
+  IdeLspPluginFormatterClass *klass = (IdeLspPluginFormatterClass *)(((GTypeInstance *)resolver)->g_class);
+  g_autoptr(IdeLspServiceClass) service_class = g_type_class_ref (klass->info->service_type);
+
+  ide_lsp_service_class_bind_client (service_class, IDE_OBJECT (resolver));
+}
+
+static void
+ide_lsp_plugin_formatter_class_init (IdeLspPluginFormatterClass *klass,
+                                     IdeLspPluginInfo           *info)
+{
+  klass->info = info;
+}
+
+static void
+ide_lsp_plugin_formatter_iface_init (IdeFormatterInterface *iface)
+{
+  iface->load = ide_lsp_plugin_formatter_load;
+}
+
+G_GNUC_BEGIN_IGNORE_DEPRECATIONS
+GObject *
+ide_lsp_plugin_create_formatter (guint             n_parameters,
+                                       GParameter       *parameters,
+                                       IdeLspPluginInfo *info)
+{
+  ide_lsp_plugin_remove_plugin_info_param (&n_parameters, parameters);
+
+  if G_UNLIKELY (info->formatter_type == G_TYPE_INVALID)
+    {
+      g_autofree char *name = g_strconcat (info->module_name, "+Formatter", NULL);
+
+      info->formatter_type =
+        g_type_register_static (IDE_TYPE_LSP_FORMATTER,
+                                name,
+                                &(GTypeInfo) {
+                                  sizeof (IdeLspPluginFormatterClass),
+                                  NULL,
+                                  NULL,
+                                  (GClassInitFunc)ide_lsp_plugin_formatter_class_init,
+                                  NULL,
+                                  ide_lsp_plugin_info_ref (info),
+                                  sizeof (IdeLspFormatter),
+                                  0,
+                                  NULL,
+                                  NULL,
+                                },
+                                G_TYPE_FLAG_FINAL);
+      g_type_add_interface_static (info->formatter_type,
+                                   IDE_TYPE_FORMATTER,
+                                   &(GInterfaceInfo) {
+                                     (GInterfaceInitFunc)(void (*) 
(void))ide_lsp_plugin_formatter_iface_init,
+                                     NULL,
+                                     NULL,
+                                   });
+    }
+
+  return g_object_newv (info->formatter_type, n_parameters, parameters);
+}
+G_GNUC_END_IGNORE_DEPRECATIONS
diff --git a/src/libide/lsp/ide-lsp-plugin-private.h b/src/libide/lsp/ide-lsp-plugin-private.h
index 1eae226de..66cfac117 100644
--- a/src/libide/lsp/ide-lsp-plugin-private.h
+++ b/src/libide/lsp/ide-lsp-plugin-private.h
@@ -35,6 +35,7 @@ typedef struct _IdeLspPluginInfo
   GType service_type;
   GType completion_provider_type;
   GType diagnostic_provider_type;
+  GType formatter_type;
   GType hover_provider_type;
   GType rename_provider_type;
   GType symbol_resolver_type;
@@ -52,6 +53,9 @@ GObject          *ide_lsp_plugin_create_completion_provider (guint             n
 GObject          *ide_lsp_plugin_create_diagnostic_provider (guint             n_parameters,
                                                              GParameter       *parameters,
                                                              IdeLspPluginInfo *info);
+GObject          *ide_lsp_plugin_create_formatter           (guint             n_parameters,
+                                                             GParameter       *parameters,
+                                                             IdeLspPluginInfo *info);
 GObject          *ide_lsp_plugin_create_hover_provider      (guint             n_parameters,
                                                              GParameter       *parameters,
                                                              IdeLspPluginInfo *info);
diff --git a/src/libide/lsp/ide-lsp-plugin.c b/src/libide/lsp/ide-lsp-plugin.c
index 4e4f7bf1c..8a3f14304 100644
--- a/src/libide/lsp/ide-lsp-plugin.c
+++ b/src/libide/lsp/ide-lsp-plugin.c
@@ -206,14 +206,6 @@ ide_lsp_plugin_highlighter_factory (guint       n_parameters,
   return ide_lsp_plugin_factory (user_data, IDE_TYPE_LSP_HIGHLIGHTER, n_parameters, parameters);
 }
 
-static GObject *
-ide_lsp_plugin_formatter_factory (guint       n_parameters,
-                                  GParameter *parameters,
-                                  gpointer    user_data)
-{
-  return ide_lsp_plugin_factory (user_data, IDE_TYPE_LSP_FORMATTER, n_parameters, parameters);
-}
-
 static GObject *
 ide_lsp_plugin_code_action_factory (guint       n_parameters,
                                     GParameter *parameters,
@@ -278,7 +270,7 @@ ide_lsp_plugin_register (PeasObjectModule     *object_module,
   if ((features & IDE_LSP_PLUGIN_FEATURES_FORMATTER) != 0)
     peas_object_module_register_extension_factory (object_module,
                                                    IDE_TYPE_FORMATTER,
-                                                   ide_lsp_plugin_formatter_factory,
+                                                   (PeasFactoryFunc)ide_lsp_plugin_create_formatter,
                                                    ide_lsp_plugin_info_ref (info),
                                                    (GDestroyNotify)ide_lsp_plugin_info_unref);
 
diff --git a/src/libide/lsp/meson.build b/src/libide/lsp/meson.build
index c1e817a21..18f841d2a 100644
--- a/src/libide/lsp/meson.build
+++ b/src/libide/lsp/meson.build
@@ -59,6 +59,7 @@ libide_lsp_public_sources = [
   'ide-lsp-plugin-completion-provider.c',
   'ide-lsp-plugin-diagnostic-provider.c',
   'ide-lsp-plugin-hover-provider.c',
+  'ide-lsp-plugin-formatter.c',
   'ide-lsp-plugin-rename-provider.c',
   'ide-lsp-plugin-symbol-resolver.c',
   'ide-lsp-rename-provider.c',