[gnome-control-center] object-cache: Avoid use after free of task error
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center] object-cache: Avoid use after free of task error
- Date: Wed, 19 Oct 2022 19:10:34 +0000 (UTC)
commit f00fd653cb7b8bc33cc84615b1c75ff878c847b0
Author: Barnabás Pőcze <pobrn protonmail com>
Date: Wed Oct 19 19:42:27 2022 +0200
object-cache: Avoid use after free of task error
The error should not be touched after passing it to
`g_task_return_error()` as noted by its documentation:
Note that since the task takes ownership of @error, and since the
task may be completed before returning from g_task_return_error(),
you cannot assume that @error is still valid after calling this.
However, previously, the code did try to free error since the
`local_error` was defined with `g_autoptr(GError)`.
shell/cc-object-storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/shell/cc-object-storage.c b/shell/cc-object-storage.c
index f52ba5960..f9a08f3ab 100644
--- a/shell/cc-object-storage.c
+++ b/shell/cc-object-storage.c
@@ -91,7 +91,7 @@ create_dbus_proxy_in_thread_cb (GTask *task,
if (local_error)
{
- g_task_return_error (task, local_error);
+ g_task_return_error (task, g_steal_pointer (&local_error));
return;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]