[glib/wip/3v1n0/support-can-fail-tests: 3/7] tests: Mark should_fail tests as can_fail
- From: Marco Trevisan <marcotrevi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/wip/3v1n0/support-can-fail-tests: 3/7] tests: Mark should_fail tests as can_fail
- Date: Thu, 20 Oct 2022 01:15:24 +0000 (UTC)
commit 565c165f8efdf91a6c83ff2a66369c9e13fd8ffb
Author: Marco Trevisan (TreviƱo) <mail 3v1n0 net>
Date: Wed Oct 19 23:52:13 2022 +0200
tests: Mark should_fail tests as can_fail
Even if they are expected to fail, we should not use an inverse logic
for treating their return codes.
gio/tests/meson.build | 18 ++++++++----------
glib/tests/meson.build | 4 ++--
2 files changed, 10 insertions(+), 12 deletions(-)
---
diff --git a/gio/tests/meson.build b/gio/tests/meson.build
index 8c1f7a9e79..6df3baf824 100644
--- a/gio/tests/meson.build
+++ b/gio/tests/meson.build
@@ -46,7 +46,7 @@ giotypefuncs_inc = custom_target(
gio_tests = {
'appmonitor' : {
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392
- 'should_fail' : host_system == 'darwin',
+ 'can_fail' : host_system == 'darwin',
},
'async-close-output-stream' : {},
'async-splice-output-stream' : {},
@@ -56,7 +56,7 @@ gio_tests = {
'contexts' : {},
'contenttype' : {
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392 /
https://gitlab.gnome.org/GNOME/glib/-/issues/1251
- 'should_fail' : host_system == 'darwin',
+ 'can_fail' : host_system == 'darwin',
},
'converter-stream' : {},
'credentials' : {},
@@ -68,14 +68,13 @@ gio_tests = {
'filter-streams' : {},
'giomodule' : {
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392
- 'should_fail' : host_system == 'darwin',
+ 'can_fail' : host_system == 'darwin',
},
'gsubprocess' : {},
'g-file' : {},
'g-file-info' : {
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392
- 'should_fail' : host_system == 'darwin',
- 'can_fail' : host_system == 'windows',
+ 'can_fail' : host_system in ['darwin', 'windows'],
},
'g-icon' : {},
'gdbus-addresses' : {},
@@ -84,8 +83,7 @@ gio_tests = {
'dependencies' : [libgdbus_example_objectmanager_dep],
'install_rpath' : installed_tests_execdir,
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392
- 'should_fail' : host_system == 'darwin',
- 'can_fail' : host_system == 'windows',
+ 'can_fail' : host_system in ['darwin', 'windows'],
},
'inet-address' : {},
'io-stream' : {},
@@ -108,7 +106,7 @@ gio_tests = {
'sleepy-stream' : {},
'socket' : {
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392
- 'should_fail' : host_system == 'darwin',
+ 'can_fail' : host_system == 'darwin',
},
'socket-listener' : {},
'socket-service' : {},
@@ -126,7 +124,7 @@ gio_tests = {
'unix-fd' : {},
'gdbus-address-get-session' : {
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392
- 'should_fail' : host_system == 'darwin',
+ 'can_fail' : host_system == 'darwin',
},
'win32-appinfo' : {},
}
@@ -866,7 +864,7 @@ if meson.can_run_host_binaries()
'resources' : {
'extra_sources' : resources_extra_sources,
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392
- 'should_fail' : host_system == 'darwin',
+ 'can_fail' : host_system == 'darwin',
},
}
endif
diff --git a/glib/tests/meson.build b/glib/tests/meson.build
index 1251315e47..7b84c6f585 100644
--- a/glib/tests/meson.build
+++ b/glib/tests/meson.build
@@ -18,12 +18,12 @@ glib_tests = {
'dataset' : {},
'date' : {
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392
- 'should_fail' : host_system == 'darwin',
+ 'can_fail' : host_system == 'darwin',
},
'dir' : {},
'environment' : {
# FIXME: https://gitlab.gnome.org/GNOME/glib/-/issues/1392
- 'should_fail' : host_system == 'darwin',
+ 'can_fail' : host_system == 'darwin',
},
'error' : {},
'fileutils' : {},
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]