[gtk/gtk-4-6: 9/15] paned: Protect against NULL variable
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/gtk-4-6: 9/15] paned: Protect against NULL variable
- Date: Mon, 12 Sep 2022 23:33:55 +0000 (UTC)
commit 7604eb1e3913bd7b6cdf09f93afdd52d03ca2b27
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Tue Aug 9 13:11:01 2022 -0300
paned: Protect against NULL variable
The inner loop in gtk_paned_set_focus_child() tries to find the
topmost GtkPaned, however, if the `w` variable ends up becoming
NULL after bubbling up the entire GtkWidget hierarchy, this loop
never breaks.
Check for NULL in this loop.
Closes https://gitlab.gnome.org/GNOME/gtk/-/issues/5094
gtk/gtkpaned.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gtk/gtkpaned.c b/gtk/gtkpaned.c
index bc7591a3d7..b0397f500c 100644
--- a/gtk/gtkpaned.c
+++ b/gtk/gtkpaned.c
@@ -1995,7 +1995,7 @@ gtk_paned_set_focus_child (GtkWidget *widget,
/* If there is one or more paned widgets between us and the
* focus widget, we want the topmost of those as last_focus
*/
- for (w = last_focus; w != GTK_WIDGET (paned); w = gtk_widget_get_parent (w))
+ for (w = last_focus; w && w != GTK_WIDGET (paned); w = gtk_widget_get_parent (w))
if (GTK_IS_PANED (w))
last_focus = w;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]