[gnome-build-meta/sam/openqa-test-fixes: 9/9] openqa: Fix Perl issues in the tests
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-build-meta/sam/openqa-test-fixes: 9/9] openqa: Fix Perl issues in the tests
- Date: Fri, 16 Sep 2022 12:11:28 +0000 (UTC)
commit d438c4184336207b4d1973dca495c1eabb1a005c
Author: Sam Thursfield <sam thursfield codethink co uk>
Date: Wed Sep 14 11:47:53 2022 +0100
openqa: Fix Perl issues in the tests
Updates in the openqa_worker container mean that we need
to tighten up some syntax that is being rejected by Perl.
There should be no functional changes to the tests.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/1766>
openqa/lib/gnomeutils.pm | 2 +-
openqa/tests/gnome_install.pm | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/openqa/lib/gnomeutils.pm b/openqa/lib/gnomeutils.pm
index 75fd7b2ef..0eb396c22 100644
--- a/openqa/lib/gnomeutils.pm
+++ b/openqa/lib/gnomeutils.pm
@@ -11,7 +11,7 @@ sub run_command {
send_key('esc');
wait_still_screen(2);
- send_key($desktop_runner_hotkey, wait_screen_change => true);
+ send_key($desktop_runner_hotkey, wait_screen_change => 1);
assert_screen('desktop_runner', $desktop_runner_timeout);
diff --git a/openqa/tests/gnome_install.pm b/openqa/tests/gnome_install.pm
index d6c354768..0b8a6006d 100644
--- a/openqa/tests/gnome_install.pm
+++ b/openqa/tests/gnome_install.pm
@@ -4,11 +4,11 @@ use testapi;
sub run {
my $self = shift;
- assert_and_click('gnome_install_1', timeout => 120, 'left');
- assert_and_click('gnome_install_disk', 'left', 10);
- assert_and_click('gnome_install_disk2', 'left', 10);
- assert_screen('gnome_install_reformatting1', 120);
- assert_screen('gnome_install_complete', 120);
+ assert_and_click('gnome_install_1', timeout => 120, button => 'left');
+ assert_and_click('gnome_install_disk', timeout => 10, button => 'left');
+ assert_and_click('gnome_install_disk2', timeout => 10, button => 'left');
+ assert_screen('gnome_install_reformatting1', timeout => 120);
+ assert_screen('gnome_install_complete', timeout => 120);
eject_cd;
power('reset');
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]