Re: meat-grinder patch

[Gediminas Paulauskas <menesis delfi lt>]

Buvo Tr, 2001-12-19 11:51-0600, kai Chema Celorio rašė:
> On Wed, 2001-12-19 at 10:54, Havoc Pennington wrote:
> > 
> > Josh Barrow <drleary mac com> writes:
> > > -static char *temporary_file = NULL;
> > > +static gchar *temporary_file = NULL;
> > 
> > For future reference, many of us consider "gchar" and "gint" to be
> > stupid and don't use them. (e.g. Pango does not use them, I don't use
> 
> And some of us, always use gchar and gint for consistency.
> All my code has g's before variable types, i feel like i am using
> "glib's set of types" even if they don't change anything. I also don't
> have to think what is shorter/longer to type ? does this type makes a
> difference ? etc.

It makes difference only in new code. Write that way you prefer.
However doing such changes as s/int/gint/ is pointless. It makes tracking
changes in CVS more difficult, as does re-indenting. Try not to do
such changes IMHO. Try stick with the indenting style which is already used
in surrounding code. Darin always notes that "this change is not neccessary,
please remove it from patch".

I'd suggest to use just int and char, unless you use more g* types in the same
code. OTOH, do you remember what gpointer stands for? void*
Even this is shorter to type... But gpointer is clearer.

-- 
Gediminas Paulauskas] [http://03bar.ktu.lt/~menesis/] [ICQ 24859336]