Re: About my gnome-utils (gsearchtool) patch

["Kevin Vandersloot" <kfv101 psu edu>]

Hi Gaute. I haven't got a chance to look at it. It might be a little late at
this stage to add this change, but maybe it will get in.

On the topic of indenting you shouldn't run indent on the source. The proper
solution is to try your best to adhere to whatever coding standards are used
in the specific source file. As the patch stands right now it is pretty much
unreadable since nearly every line is changed.

Also, in the future you can direct questions to the bug report and I can
respond to them there.

Regards,
Kevin

----- Original Message -----
From: "Gaute Lindkvist" <lindkvis stud ntnu no>
To: <desktop-devel-list gnome org>
Sent: Wednesday, April 24, 2002 2:04 PM
Subject: About my gnome-utils (gsearchtool) patch


> Did anyone look at it? I was just wondering if I need to change it, or
> wether it will make it to GNOME 2.0 at all?
>
> It isn't really nearly as complex as it looks. It's just it didn't seem to
> be indented after standard(*)... so indenting it after my fixing made diff
> think just about everything in gsearchtool.c had changed.
>
> http://bugzilla.gnome.org/show_bug.cgi?id=78865
>
> Gaute Lindkvist
>
> (*) If I should use anything else than "indent -kr -i8 -pcs -lps -psl"
> please let me know.
>