Re: gnome-about ported to Gnome 2.0

[Mark McLoughlin <mark skynet ie>]

Hi Jacob,

On 21 Feb 2002, jacob berkman wrote:

> On Thu, 2002-02-21 at 11:40, Deepa Chacko Pillai wrote:
> > Hi
> >
> > I have ported gnome-about to GNOME 2.0. I have removed all the
> > deprecated calls except for GdkFont. I will deliver a separate patch
> > once I am done with that. I will make the session management changes
> > also in the next patch.
>
> i would remove:
>
> >  static void
> > -unref_gdk_pixbuf (GtkObject *object, gpointer data)
> > +unref_gdk_pixbuf (GObject *object, gpointer data)
> >  {
> > -	gdk_pixbuf_unref (data);
> > +	g_object_unref (data);
> >  }
>
> and change:
>
> > +	g_signal_connect (G_OBJECT (image), "destroy",
> > +			  G_CALLBACK (unref_gdk_pixbuf), im);
>
> to:
>
> 	g_signal_connect_swapped (image, "destroy",
> 				  G_CALLBACK (g_object_unref),
> 				  im);

	Pure laziness on my part not to point this out. I spotted, but
couldn't have been bothered. Bad, bad me :-)

	I'll sort it out ...

Good Luck,
Mark.