Re: [patch] Set save_selected from autosave

[jacob berkman <jacob ximian com>]

On Tue, 2002-06-04 at 14:30, Gustavo Giráldez wrote:
> On Tue, 2002-06-04 at 12:52, jacob berkman wrote: 
> > On Tue, 2002-06-04 at 06:36, Gustavo Giráldez wrote:
> > > Hi,
> > > 
> > > The attached patch set save_selected in maybe_display_gui.  This is
> > > necessary for saving the session when the option prompt on logout is
> > > unchecked, since otherwise in maybe_run_discard_commands the new discard
> > > command is run, and of course it erases the currently saved data.
> > 
> > so gnome-session-properties has this for you in the first tab:
> > 
> > [ ] prompt on logout
> > [ ] automatically save session
> > 
> > ?
> > 
> > and, are you expecting it to save your session?
> 
> Err... no.  I have: 
> 
> [ ] prompt on logout
> [X] automatically save session
> 
> so I do expect it to save my session.  In the situation you describe I
> don't have problems (i.e. session is not saved, so
> maybe_run_discard_commands is not run, so no session data is lost).

ok, this patch isn't right then.

in manager.c:maybe_write_session(), you can see that it checks autosave
|| save_selected before writing the session.

does the attached patch work for you?

> Sorry, I really don't know how to explain this better (my English
> vocabulary is limited).  I hope it's more clear now.

yes, perfectly.

thanks,
 - jacob