Re: panel launcher click feedback

[Jacob Berkman <jacob ximian com>]

On Wed, 2002-09-18 at 19:50, Mark McLoughlin wrote:
> Hi Jacob,
> 
> On 18 Sep 2002, jacob berkman wrote:
> 
> > this patch adds some zoom animation when you launch a panel launcher.
> >
> 	The multihead stuff is no longer conditional on HEAD. I took
> hp's lead on this when committing the multihead patches for libwnck
> and did the same for the panel.

yay.

> 
> > is this ok to go into HEAD?
> 
> 	The patch looks okay, but I've a few comments:
> 
> 	* I'm nervous about the server grab - I know its neccessary
> 	  for IncludeInferiors but given that the server grab for the
> 	  logout iris is causing a lockup with accessibility ...

that is because there is gtk interaction while the grab is taken.  in
this code, the server is only grabbed for a short time, and the gtk main
loop doesn't get run.

> 	* I'd prefer if the animation code used gdk rather than Xlib.
> 	  The only GCValues member used by the code and not exported
> 	  by gdk is plane_mask. Maybe I'm stupid but I don't see what
> 	  would be wrong with using AllPlanes on a PsuedoColor visual.
> 	  In any case, if it uses Xlib could you put it in xstuff.c.

it uses Xlib because wmaker uses just xlib.  i can port it to gdk but...
it doesn't seem like a worthwhile venture :/

if you really want me to let me know...

 - jacob