Re: 2.5 crashing in gdk_pixbuf_new_from_file()

[Jonathan Blandford <jrb redhat com>]

iain <iain prettypeople org> writes:

> Benjamin is working on fixed the gst bug at the moment.

This patch should fix it.

-Jonathan

? ext/smoothwave/demo-osssrc
? gst/level/demo
? gst/level/plot
Index: ChangeLog
===================================================================
RCS file: /cvsroot/gstreamer/gst-plugins/ChangeLog,v
retrieving revision 1.13
diff -u -p -r1.13 ChangeLog
--- ChangeLog	12 Jul 2003 12:49:14 -0000	1.13
+++ ChangeLog	9 Nov 2003 00:27:58 -0000
@@ -1,3 +1,8 @@
+Sat Nov  8 19:26:30 2003  Jonathan Blandford  <jrb gnome org>
+
+	* ext/gdk_pixbuf/gst_loader.c (fill_info): escape any embedded
+	nulls.
+
 2003-07-12  Thomas Vander Stichele <thomas at apestaart dot org>
 
         * gst-plugins.spec.in: fix up spec file
Index: ext/gdk_pixbuf/gst_loader.c
===================================================================
RCS file: /cvsroot/gstreamer/gst-plugins/ext/gdk_pixbuf/gst_loader.c,v
retrieving revision 1.1
diff -u -p -r1.1 gst_loader.c
--- ext/gdk_pixbuf/gst_loader.c	5 Nov 2003 03:24:53 -0000	1.1
+++ ext/gdk_pixbuf/gst_loader.c	9 Nov 2003 00:27:59 -0000
@@ -43,7 +43,7 @@ fill_info (GdkPixbufFormat *info)
 {
   static GdkPixbufModulePattern signature[] = {
     { "RIFF    AVI ", "    xxxx    ", 100 },
-    { "\000\000\001\272", "", 100 },
+    { "xx\001\272", "zz  ", 100 },
     { NULL, NULL, 0 }
   };