Re: patch to gnome-session: smooth fade on logout

[James Henstridge <james daa com au>]

On 21/04/2004 10:57 AM, Ross Girshick wrote:

> Hello,
>
> For a while I've been annoyed by the choppy fade when logging out. This
> is especially a problem on a high resolution laptop displays when
> throttling CPU performance. Below is a patch to provide a smooth
> fadeout. I've tested it on a 1400x1050 display with the CPU throttling
> between 600MHz and 1.6GHz -- fading was nice and smooth. This is also
> the first patch that I'm submitting to the gnome community over a
> mailing list and directly to maintainers, so if I'm breaking and
> etticate please let me know. I hope to become a gnome developer in the
> future.
>  
Judging by the patch, the original code is designed to perform a fade 
out over a fixed period of time (so slower machines would render less 
frames in the animation).  Your patch appears to change things so that 
it fades out in a fixed number of frames.  How will this affect the time 
required to log out on slower machines?

James.

--
Email: james daa com au
WWW:   http://www.daa.com.au/~james/