On Sat, 2004-05-22 at 20:19 +0800, Davyd Madeley wrote: > On Sat, 2004-05-22 at 20:14 +0800, Davyd Madeley wrote: > > > > Looking at the patch it also seems to me that you are leaking the > > > new_label string when creating the dialog... beside gnome_*_dialog are > > > deprecated and should be replaced with gtk_message_dialogs. > > > > Hmm, I'm not intentionally leaking the label. I think that may have been > > there a while now. I know about the deprecation of gnome_*_dialog-s, > > however I haven't gotten around to changing them yet. > > It will have to happen though. > > Checking the code... > new_label is defined statically and snprintf'ed into. Why not g_strdup_printf'ed into? It's the glibby thing to do... -- m -- Mariano Suárez-Alvarez <mariano gnome org>
Attachment:
signature.asc
Description: This is a digitally signed message part